r96683 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96682‎ | r96683 | r96684 >
Date:19:02, 9 September 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
using wgExtensionAssetsPath, changing confusing card error to card_type error
Modified paths:
  • /branches/fundraising/extensions/DonationInterface/gateway_forms/RapidHtml.php (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/gateway_forms/html/globalcollect_test.html (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/gateway_forms/html/globalcollect_test_2.html (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)
  • /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)

Diff [purge]

Index: branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
@@ -63,6 +63,7 @@
6464 'payflowpro_gateway-error-msg-state' => 'state',
6565 'payflowpro_gateway-error-msg-zip' => 'postal code',
6666 'payflowpro_gateway-error-msg-country' => 'country',
 67+ 'payflowpro_gateway-error-msg-card_type' => 'credit card type',
6768 'payflowpro_gateway-error-msg-card_num' => 'credit card number',
6869 'payflowpro_gateway-error-msg-expiration' => "card's expiration date",
6970 'payflowpro_gateway-error-msg-cvv' => 'CVV from the back of your card',
Index: branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -70,6 +70,7 @@
7171 'payflowproGatewayErrorMsgState' => wfMsg( 'payflowpro_gateway-error-msg-state' ),
7272 'payflowproGatewayErrorMsgZip' => wfMsg( 'payflowpro_gateway-error-msg-zip' ),
7373 'payflowproGatewayErrorMsgCountry' => wfMsg( 'payflowpro_gateway-error-msg-country' ),
 74+ 'payflowproGatewayErrorMsgCardType' => wfMsg( 'payflowpro_gateway-error-msg-card_type' ),
7475 'payflowproGatewayErrorMsgCardNum' => wfMsg( 'payflowpro_gateway-error-msg-card_num' ),
7576 'payflowproGatewayErrorMsgExpiration' => wfMsg( 'payflowpro_gateway-error-msg-expiration' ),
7677 'payflowproGatewayErrorMsgCvv' => wfMsg( 'payflowpro_gateway-error-msg-cvv' ),
@@ -966,7 +967,7 @@
967968 'size' => 'small',
968969 'premium_language' => 'es',
969970 'card_num' => $card_nums[ $cards[ $card_index ]][ $card_num_index ],
970 - 'card' => $cards[ $card_index ],
 971+ 'card_type' => $cards[ $card_index ],
971972 'expiration' => date( 'my', strtotime( '+1 year 1 month' ) ),
972973 'cvv' => '001',
973974 'currency' => 'USD',
@@ -1019,7 +1020,7 @@
10201021 'size' => $wgRequest->getText( 'size' ),
10211022 'premium_language' => $wgRequest->getText( 'premium_language', "en" ),
10221023 'card_num' => str_replace( ' ', '', $wgRequest->getText( 'card_num' ) ),
1023 - 'card' => $wgRequest->getText( 'card' ),
 1024+ 'card_type' => $wgRequest->getText( 'card_type' ),
10241025 'expiration' => $wgRequest->getText( 'mos' ) . substr( $wgRequest->getText( 'year' ), 2, 2 ),
10251026 'cvv' => $wgRequest->getText( 'cvv' ),
10261027 'currency' => $wgRequest->getText( 'currency_code' ),
@@ -1073,7 +1074,7 @@
10741075 'retryMsg' => '',
10751076 'invalidamount' => '',
10761077 'card_num' => '',
1077 - 'card' => '',
 1078+ 'card_type' => '',
10781079 'cvv' => '',
10791080 'fname' => '',
10801081 'lname' => '',
Index: branches/fundraising/extensions/DonationInterface/gateway_forms/html/globalcollect_test.html
@@ -140,7 +140,7 @@
141141 </td>
142142 </tr>
143143 <tr>
144 - <td colspan="2"><span class="creditcard-error-msg">#card#card_num</span></td>
 144+ <td colspan="2"><span class="creditcard-error-msg">#card_num</span></td>
145145 </tr>
146146 <tr>
147147 <td class="label"><label for="card_num">Card number</label></td>
Index: branches/fundraising/extensions/DonationInterface/gateway_forms/html/globalcollect_test_2.html
@@ -172,7 +172,7 @@
173173 </td>
174174 </tr>
175175 <tr>
176 - <td colspan=2><span class="creditcard-error-msg">#card#card_num</span></td>
 176+ <td colspan=2><span class="creditcard-error-msg">#card_num</span></td>
177177 <tr>
178178 <tr>
179179 <td class="label"><label for="card_num">Card number</label></td>
Index: branches/fundraising/extensions/DonationInterface/gateway_forms/RapidHtml.php
@@ -28,7 +28,7 @@
2929 '@zip', // => $wgRequest->getText( 'zip' ),
3030 '@country', // => $wgRequest->getText( 'country' ),
3131 '@card_num', // => str_replace( ' ', '', $wgRequest->getText( 'card_num' ) ),
32 - '@card', // => $wgRequest->getText( 'card' ),
 32+ '@card_type', // => $wgRequest->getText( 'card_type' ),
3333 '@expiration', // => $wgRequest->getText( 'mos' ) . substr( $wgRequest->getText( 'year' ), 2, 2 ),
3434 '@cvv', // => $wgRequest->getText( 'cvv' ),
3535 '@currency_code', //'currency' => $wgRequest->getText( 'currency_code' ),
@@ -67,7 +67,7 @@
6868 '#retryMsg',
6969 '#amount',
7070 '#card_num',
71 - '#card',
 71+ '#card_type',
7272 '#cvv',
7373 '#fname',
7474 '#lname',
Index: branches/fundraising/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php
@@ -54,11 +54,11 @@
5555 * @param $par Mixed: parameter passed to the page or null
5656 */
5757 public function execute( $par ) {
58 - global $wgRequest, $wgOut, $wgScriptPath,
 58+ global $wgRequest, $wgOut, $wgExtensionAssetsPath,
5959 $wgPayFlowProGatewayCSSVersion;
6060
6161 $wgOut->addExtensionStyle(
62 - "{$wgScriptPath}/extensions/DonationInterface/gateway_forms/css/gateway.css?284" .
 62+ $wgExtensionAssetsPath . '/DonationInterface/gateway_forms/css/gateway.css?284' .
6363 $wgPayFlowProGatewayCSSVersion );
6464
6565 $scriptVars = array(
@@ -73,6 +73,7 @@
7474 'globalcollectGatewayErrorMsgState' => wfMsg( 'globalcollect_gateway-error-msg-state' ),
7575 'globalcollectGatewayErrorMsgZip' => wfMsg( 'globalcollect_gateway-error-msg-zip' ),
7676 'globalcollectGatewayErrorMsgCountry' => wfMsg( 'globalcollect_gateway-error-msg-country' ),
 77+ 'globalcollectGatewayErrorMsgCardType' => wfMsg( 'globalcollect_gateway-error-msg-card_type' ),
7778 'globalcollectGatewayErrorMsgCardNum' => wfMsg( 'globalcollect_gateway-error-msg-card_num' ),
7879 'globalcollectGatewayErrorMsgExpiration' => wfMsg( 'globalcollect_gateway-error-msg-expiration' ),
7980 'globalcollectGatewayErrorMsgCvv' => wfMsg( 'globalcollect_gateway-error-msg-cvv' ),
@@ -586,7 +587,7 @@
587588 'retryMsg' => '',
588589 'invalidamount' => '',
589590 'card_num' => '',
590 - 'card' => '',
 591+ 'card_type' => '',
591592 'cvv' => '',
592593 'fname' => '',
593594 'lname' => '',

Follow-up revisions

RevisionCommit summaryAuthorDate
r100646A couple changes to the rapidHTML forms that became necessary after the merge...khorn21:26, 24 October 2011

Status & tagging log