r96682 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96681‎ | r96682 | r96683 >
Date:19:01, 9 September 2011
Author:brion
Status:ok
Tags:
Comment:
Followup r96679 -- fix for dumb mistake in merge

The code calling addScript from one function was accidentally not hoisted out of a function, turning it into dead code and causing a lot of modules not to get loaded.
This is why we have two people test things before we deploy them -- but even then some things slip through eh ;)
Modified paths:
  • /branches/wmf/1.17wmf1/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/resources/mediawiki/mediawiki.js
——@@ -853,12 +853,10 @@
854854 // include modules which are already loaded
855855 batch = [];
856856 // Asynchronously append a script tag to the end of the body
857 - function request() {
858 - for ( var r = 0; r < requests.length; r++ ) {
859 - requests[r] = sortQuery( requests[r] );
860 - var src = mediaWiki.config.get( 'wgLoadScript' ) + '?' + $.param( requests[r] );
861 - addScript( src );
862 - }
 857+ for ( var r = 0; r < requests.length; r++ ) {
 858+ requests[r] = sortQuery( requests[r] );
 859+ var src = mediaWiki.config.get( 'wgLoadScript' ) + '?' + $.param( requests[r] );
 860+ addScript( src );
863861 }
864862 }
865863 };

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96679MFT r87986 -- consolidation of addScript in mediawiki.loader, also fixes bug ...brion18:39, 9 September 2011

Status & tagging log