r100646 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100645‎ | r100646 | r100647 >
Date:21:26, 24 October 2011
Author:khorn
Status:ok
Tags:fundraising 
Comment:
A couple changes to the rapidHTML forms that became necessary after the merge ('card' became 'card_type').
Related to r96683.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/globalcollect_test.html (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/globalcollect_test_2.html (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/webitects_1.html (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/webitects_1a.html (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/webitects_2.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/globalcollect_test.html
@@ -140,7 +140,7 @@
141141 </td>
142142 </tr>
143143 <tr>
144 - <td colspan="2"><span class="creditcard-error-msg">#card#card_num</span></td>
 144+ <td colspan="2"><span class="creditcard-error-msg">#card_type#card_num</span></td>
145145 </tr>
146146 <tr>
147147 <td class="label"><label for="card_num">Card number</label></td>
Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/globalcollect_test_2.html
@@ -95,7 +95,7 @@
9696 </td>
9797 </tr>
9898 <tr>
99 - <td colspan=2><span class="creditcard-error-msg">#card#card_num</span></td>
 99+ <td colspan=2><span class="creditcard-error-msg">#card_type#card_num</span></td>
100100 <tr>
101101 <tr>
102102 <td class="label"><label for="card_num">Card number</label></td>
Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/webitects_1.html
@@ -224,7 +224,7 @@
225225 }
226226
227227 // check for RapidHtml errors and display, if any
228 - var errors = ['#general','#retryMsg','#amount','#card_num','#card','#cvv','#fname',
 228+ var errors = ['#general','#retryMsg','#amount','#card_num','#card_type','#cvv','#fname',
229229 '#lname','#city','#country','#street','#state','#zip','#emailAdd'];
230230
231231 var count = 0;
Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/webitects_1a.html
@@ -225,7 +225,7 @@
226226 }
227227
228228 // check for RapidHtml errors and display, if any
229 - var errors = ['#general','#retryMsg','#amount','#card_num','#card','#cvv','#fname',
 229+ var errors = ['#general','#retryMsg','#amount','#card_num','#card_type','#cvv','#fname',
230230 '#lname','#city','#country','#street','#state','#zip','#emailAdd'];
231231
232232 var count = 0;
Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/html/webitects_2.html
@@ -235,7 +235,7 @@
236236 }
237237
238238 // check for RapidHtml errors and display, if any
239 - var errors = ['#general','#retryMsg','#amount','#card_num','#card','#cvv','#fname',
 239+ var errors = ['#general','#retryMsg','#amount','#card_num','#card_type','#cvv','#fname',
240240 '#lname','#city','#country','#street','#state','#zip','#emailAdd'];
241241
242242 var count = 0;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96683using wgExtensionAssetsPath, changing confusing card error to card_type errorkaldari19:02, 9 September 2011

Status & tagging log