r96653 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96652‎ | r96653 | r96654 >
Date:09:27, 9 September 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Fixed a bug in r52157. Special pages with spaces in their names would cause problems. Bad me.
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuth.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuth.i18n.php
@@ -18,7 +18,7 @@
1919 'centralauth-desc' => '[[Special:MergeAccount|Merge account]] across wikis of {{MediaWiki:Centralauth-groupname}}',
2020 'centralauth-mergeaccount-desc' => '[[Special:MergeAccount|Merges multiple accounts]] for Single User Login',
2121 'centralauth-merge-denied' => 'Sorry, you do not have permission to access this page.',
22 - 'centralauth-merge-notlogged' => 'Please <span class="plainlinks">[{{fullurl:{{#special:UserLogin}}|returnto={{#special:MergeAccount}}}} log in]</span> to check if your accounts have been fully merged.',
 22+ 'centralauth-merge-notlogged' => 'Please <span class="plainlinks">[{{fullurl:{{#special:UserLogin}}|returnto={{urlencode:{{#special:MergeAccount}}|WIKI}}}} log in]</span> to check if your accounts have been fully merged.',
2323 'centralauth-merge-welcome' => "'''Your user account has not yet been migrated to the unified login system of {{MediaWiki:Centralauth-groupname}}.'''
2424
2525 If you choose to migrate your accounts, you will be able to use the same username and password to log in to all wikis of {{MediaWiki:Centralauth-groupname}} in all available languages.

Follow-up revisions

RevisionCommit summaryAuthorDate
r97248Followup r96653. Reduced the amount of constant markup in the message.nikerabbit08:27, 16 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52157Convert special page names to content language, per bug 17619nikerabbit09:20, 19 June 2009

Comments

#Comment by Nikerabbit (talk | contribs)   09:29, 9 September 2011

This was actually filed as bug bug 26463.

#Comment by Siebrand (talk | contribs)   12:12, 9 September 2011

This is turning out to be a very ugly message now. Parameter time?

#Comment by Umherirrender (talk | contribs)   14:05, 9 September 2011

Or a #speciale parser function (bug 23006)

#Comment by Nikerabbit (talk | contribs)   12:15, 9 September 2011

I just wish there was way to embed links in messages in sane way.

Status & tagging log