r96652 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96651‎ | r96652 | r96653 >
Date:09:25, 9 September 2011
Author:aaron
Status:ok
Tags:
Comment:
* Don't list sp:ChangeEmail/sp:ChangePassword at SpecialPages. These were clutter, and useless for anons, as there are links on sp:Preferences for these.
* Added check for checkTemporaryPassword() to sp:ChangeEmail.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialChangeEmail.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialChangePassword.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialChangeEmail.php
@@ -26,7 +26,7 @@
2727 *
2828 * @ingroup SpecialPage
2929 */
30 -class SpecialChangeEmail extends SpecialPage {
 30+class SpecialChangeEmail extends UnlistedSpecialPage {
3131 public function __construct() {
3232 parent::__construct( 'ChangeEmail' );
3333 }
@@ -180,7 +180,7 @@
181181 return false;
182182 }
183183
184 - if ( !$user->checkPassword( $pass ) ) {
 184+ if ( !$user->checkTemporaryPassword( $pass ) && !$user->checkPassword( $pass ) ) {
185185 $this->error( wfMsgHtml( 'wrongpassword' ) );
186186 return false;
187187 }
Index: trunk/phase3/includes/specials/SpecialChangePassword.php
@@ -26,7 +26,7 @@
2727 *
2828 * @ingroup SpecialPage
2929 */
30 -class SpecialChangePassword extends SpecialPage {
 30+class SpecialChangePassword extends UnlistedSpecialPage {
3131 public function __construct() {
3232 parent::__construct( 'ChangePassword' );
3333 }

Status & tagging log