r96403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96402‎ | r96403 | r96404 >
Date:03:25, 7 September 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Move the vector styles for the user login form into commonContent.css
The vector styles are very generic and fit well as the common style. With a minor tweak to MonoBook (which actually partially fixes a bug in the signup form on Wikipedia) this style fits in perfectly without conflicting with MonoBook's styles.
Modified paths:
  • /trunk/phase3/skins/common/commonContent.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
——@@ -688,8 +688,8 @@
689689 margin-top: 2em;
690690 }
691691
692 -div#userloginForm form,
693 -div#userlogin form#userlogin2 {
 692+div#userloginForm,
 693+div#userlogin {
694694 margin: 0 3em 1em 0;
695695 border: 1px solid #aaa;
696696 clear: both;
——@@ -699,12 +699,12 @@
700700 }
701701
702702 div#userloginForm table,
703 -div#userlogin form#userlogin2 table {
 703+div#userlogin table {
704704 background-color: #f9f9f9;
705705 }
706706
707707 div#userloginForm h2,
708 -div#userlogin form#userlogin2 h2 {
 708+div#userlogin h2 {
709709 padding-top: 0;
710710 }
711711
Index: trunk/phase3/skins/common/commonContent.css
——@@ -111,3 +111,19 @@
112112 border: 1px solid #dddddd;
113113 }
114114
 115+/**
 116+ * Basic styles for the user login and create account forms
 117+ */
 118+#userlogin, #userloginForm {
 119+ border: solid 1px #cccccc;
 120+ padding: 1.2em;
 121+ margin: .5em;
 122+ float: left;
 123+}
 124+
 125+#userlogin {
 126+ min-width: 20em;
 127+ max-width: 90%;
 128+ width: 40em;
 129+}
 130+
Index: trunk/phase3/skins/vector/screen.css
——@@ -661,22 +661,6 @@
662662 margin-right: 0.25em;
663663 }
664664
665 -/*
666 - * Styles for the user login and create account forms
667 - */
668 -#userlogin, #userloginForm {
669 - border: solid 1px #cccccc;
670 - padding: 1.2em;
671 - margin: .5em;
672 - float: left;
673 -}
674 -
675 -#userlogin {
676 - min-width: 20em;
677 - max-width: 90%;
678 - width: 40em;
679 -}
680 -
681665 /*
682666 *
683667 * The following code is slightly modified from monobook

Comments

#Comment by SPQRobin (talk | contribs)   06:56, 7 September 2011

Hmm, I would say that styles for UserLogin are more 'interface' than 'content'. Content reminds me of the basic wiki pages/articles.

#Comment by SPQRobin (talk | contribs)   07:00, 7 September 2011

At least, from a language perspective it makes sense to separate content styles (styles of stuff in the wiki language) from interface styles (styles of stuff in the user language). We *might* need to load these differently at some point in the future.

#Comment by Dantman (talk | contribs)   08:01, 7 September 2011

I suppose it's not the best naming -- come up with another if you can think of one -- but essentially here the different stylesheet name meanings are:

  • element = Singular elements (a, h#, etc...) styles that style basic markup, no complex MediaWiki structures
  • content = Complex (not made up of a single element) structures which are outputted into the content area and are defined by built-in system defined internal id's and classes (toc, image frames, etc...)
  • interface = Styles that follow the the MonoBook/Vector convention of laying out the content area for structures which the skin implementation gets to decide what the id's and classes are. (usermessage, sitenotice, our firstHeader title, etc...)

Status & tagging log