r96404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96403‎ | r96404 | r96405 >
Date:03:46, 7 September 2011
Author:dantman
Status:ok
Tags:
Comment:
Move h1-5 bottom margins to commonElements, common generic siteNotice styles and firstHeading to commonInterface.
Modified paths:
  • /trunk/phase3/skins/common/commonElements.css (modified) (history)
  • /trunk/phase3/skins/common/commonInterface.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -90,27 +90,13 @@
9191 ** the main content area
9292 */
9393
94 -/* Some space under the headers in the content area */
95 -#bodyContent h1, #bodyContent h2 {
96 - margin-bottom: .6em;
97 -}
98 -#bodyContent h3, #bodyContent h4, #bodyContent h5 {
99 - margin-bottom: .3em;
100 -}
101 -#firstHeading {
102 - margin-bottom: .1em;
103 - /* These two rules hack around bug 2013 (fix for more limited bug 11325).
104 - When bug 2013 is fixed properly, they should be removed. */
105 - line-height: 1.2em;
106 - padding-bottom: 0;
107 -}
108 -
10994 #siteNotice {
110 - position: relative;
111 - text-align: center;
11295 font-size: 95%;
11396 padding: 0 0.9em;
11497 }
 98+#localNotice {
 99+ margin: 0;
 100+}
115101 #siteNotice p {
116102 margin: 0;
117103 padding: 0;
Index: trunk/phase3/skins/common/commonInterface.css
@@ -22,6 +22,26 @@
2323 vertical-align: middle;
2424 }
2525
 26+/* Site Notice (includes notices from CentralNotice extension) */
 27+#siteNotice {
 28+ position: relative;
 29+ text-align: center;
 30+ margin: 0;
 31+}
 32+#localNotice {
 33+ margin-bottom: 0.9em;
 34+}
 35+
 36+/* First h1 */
 37+.firstHeading,
 38+#firstHeading {
 39+ margin-bottom: .1em;
 40+ /* These two rules hack around bug 2013 (fix for more limited bug 11325).
 41+ When bug 2013 is fixed properly, they should be removed. */
 42+ line-height: 1.2em;
 43+ padding-bottom: 0;
 44+}
 45+
2646 /* Sub-navigation */
2747 #siteSub {
2848 display: none;
Index: trunk/phase3/skins/common/commonElements.css
@@ -103,6 +103,17 @@
104104 h6 { font-size: 80%; }
105105 h6 .editsection { font-size: 125%; font-weight: normal; }
106106
 107+/* Some space under the headers in the content area */
 108+h1,
 109+h2 {
 110+ margin-bottom: .6em;
 111+}
 112+h3,
 113+h4,
 114+h5 {
 115+ margin-bottom: .3em;
 116+}
 117+
107118 p {
108119 margin: .4em 0 .5em 0;
109120 line-height: 1.5em;
Index: trunk/phase3/skins/vector/screen.css
@@ -686,29 +686,13 @@
687687
688688 /* Site Notice (includes notices from CentralNotice extension) */
689689 #siteNotice {
690 - position: relative;
691 - text-align: center;
692690 font-size: 0.8em;
693 - margin: 0;
694691 }
695 -#localNotice {
696 - margin-bottom: 0.9em;
697 -}
698 -/* Edge Cases for Content */
699 -h1, h2 {
700 - margin-bottom: .6em;
701 -}
702 -h3, h4, h5 {
703 - margin-bottom: .3em;
704 -}
705692 #firstHeading {
706693 padding-top: 0;
707694 margin-top: 0;
708695 padding-top: 0;
709 - margin-bottom: 0.1em;
710 - line-height: 1.2em;
711696 font-size: 1.6em;
712 - padding-bottom: 0;
713697 }
714698 div#content a.external,
715699 div#content a[href ^="gopher://"] {

Status & tagging log