r96388 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96387‎ | r96388 | r96389 >
Date:23:21, 6 September 2011
Author:ben
Status:ok (Comments)
Tags:
Comment:
changed help text to indicate an optional port if nonstandard
Modified paths:
  • /trunk/phase3/maintenance/mctest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/mctest.php
@@ -29,7 +29,7 @@
3030 $this->mDescription = "Makes several 'set', 'incr' and 'get' requests on every"
3131 . " memcached server and shows a report";
3232 $this->addOption( 'i', 'Number of iterations', false, true );
33 - $this->addArg( 'server', 'Memcached server to test', false );
 33+ $this->addArg( 'server[:port]', 'Memcached server to test, with optional port', false );
3434 }
3535
3636 public function execute() {

Comments

#Comment by 😂 (talk | contribs)   23:31, 6 September 2011

That key isn't the description, it's also the name of the parameter --server. Just updating the description should be fine.

#Comment by 😂 (talk | contribs)   00:46, 7 September 2011

I got addArg() and addOption() confused. This is fine.

Status & tagging log