r96387 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96386‎ | r96387 | r96388 >
Date:23:18, 6 September 2011
Author:laner
Status:deferred
Tags:
Comment:
Script should set the user's cn and mail attributes. Fix PIPE issue, as well.
Modified paths:
  • /trunk/tools/subversion/user-management/add-labs-user (modified) (history)

Diff [purge]

Index: trunk/tools/subversion/user-management/add-labs-user
@@ -20,8 +20,12 @@
2121
2222 # Set a random password for the user
2323 passwdargs = ['/usr/local/bin/change-ldap-passwd', '--random', username]
24 - passwd = subprocess.Popen(passwdargs, stdout=PIPE).communicate()[0]
 24+ passwd = subprocess.Popen(passwdargs, stdout=subprocess.PIPE).communicate()[0]
2525
 26+ # Set the user's CN and email address
 27+ passwdargs = ['/usr/local/bin/modify-ldap-user', '--cn=' + options.wikiname, '--mail=' + options.mail, username]
 28+ ignore = subprocess.Popen(passwdargs, stdout=subprocess.PIPE).communicate()[0]
 29+
2630 # Do an initial log in as the user, which will cause the wiki to create an account
2731 # for the user.
2832 data = {'action': 'login',

Status & tagging log