r96361 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96360‎ | r96361 | r96362 >
Date:19:20, 6 September 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
-rakkaus/#mediawiki-i18n- [06-Sep-2011 19:12:04] PHP Fatal error: Call to a member function titleAttrib() on a non-object in /www/w/includes/SkinTemplate.php on line 1538
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -549,7 +549,7 @@
550550
551551 /* set up the default links for the personal toolbar */
552552 $personal_urls = array();
553 -
 553+
554554 $page = $request->getVal( 'returnto', $this->thispage );
555555 $query = $request->getVal( 'returntoquery', $this->thisquery );
556556 $a = array( 'returnto' => $page );
@@ -1535,7 +1535,7 @@
15361536 }
15371537 if ( isset( $item['single-id'] ) ) {
15381538 if ( isset( $item['tooltiponly'] ) && $item['tooltiponly'] ) {
1539 - $attrs['title'] = $this->skin->titleAttrib( $item['single-id'] );
 1539+ $attrs['title'] = $this->getSkin()->titleAttrib( $item['single-id'] );
15401540 if ( $attrs['title'] === false ) {
15411541 unset( $attrs['title'] );
15421542 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96343Small MonoBook cleanup:...dantman15:27, 6 September 2011

Comments

#Comment by Reedy (talk | contribs)   19:30, 6 September 2011

Probably caused by r96343

Status & tagging log