r96279 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96278‎ | r96279 | r96280 >
Date:14:51, 5 September 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix a strict standards notice and a fatal (!!!) in REL1_17/extensions . Both fixes made it to trunk at some point but I'm too lazy to check when
Modified paths:
  • /branches/REL1_17/extensions/AbuseFilter/AbuseFilterVariableHolder.php (modified) (history)
  • /branches/REL1_17/extensions/AntiBot/available/GenericFormEncoding.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/AbuseFilter/AbuseFilterVariableHolder.php
@@ -331,7 +331,7 @@
332332
333333 $users = array();
334334 foreach ( $res as $user ) {
335 - $users[] = $user[0];
 335+ $users[] = $user->rev_user_text;
336336 }
337337 $result = $users;
338338 break;
Index: branches/REL1_17/extensions/AntiBot/available/GenericFormEncoding.php
@@ -10,7 +10,7 @@
1111
1212 $wgHooks['EditFilterMerged'][] = 'AntiBot_GenericFormEncoding::onEditFilterMerged';
1313 class AntiBot_GenericFormEncoding {
14 - function onEditFilterMerged( $editPage, $text, &$hookError ) {
 14+ static function onEditFilterMerged( $editPage, $text, &$hookError ) {
1515 if ( !function_exists( 'apache_request_headers' ) ) {
1616 return true;
1717 }

Comments

#Comment by Jack Phoenix (talk | contribs)   20:33, 5 September 2011

AbuseFilter patch is r81959, AntiBot patch is r90770.

Status & tagging log