r96278 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96277‎ | r96278 | r96279 >
Date:13:43, 5 September 2011
Author:catrope
Status:ok
Tags:
Comment:
Revert r95631, should be enough to fix the issues with LQT edit form. TheDJ asked me to revert all of his RL-related LQT commits but that would be such a mess that I'd rather not do that.
Modified paths:
  • /trunk/extensions/LiquidThreads/LiquidThreads.php (modified) (history)
  • /trunk/extensions/LiquidThreads/api/ApiThreadAction.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/LiquidThreads.php
@@ -70,7 +70,7 @@
7171
7272 $wgResourceModules['ext.liquidThreads'] = $lqtResourceTemplate + array(
7373 'styles' => array( 'lqt.css', 'jquery/jquery.thread_collapse.css', 'lqt.dialogs.css' ),
74 - 'scripts' => array( 'lqt.js', 'jquery/jquery.thread_collapse.js', 'jquery/jquery.autogrow.js' ),
 74+ 'scripts' => array( 'lqt.js', 'js/lqt.toolbar.js', 'jquery/jquery.thread_collapse.js', 'jquery/jquery.autogrow.js' ),
7575 'dependencies' => array( 'jquery.ui.dialog', 'jquery.ui.droppable' ),
7676 'messages' => $lqtMessages
7777 );
@@ -80,13 +80,6 @@
8181 'dependencies' => array( 'ext.liquidThreads' )
8282 );
8383
84 -$wgResourceModules['ext.liquidThreads.edit'] = $lqtResourceTemplate + array(
85 - 'scripts' => array( 'js/lqt.toolbar.js' ),
86 - 'dependancies' => array( 'ext.liquidThreads', 'ext.wikiEditor', 'ext.wikiEditor.toolbar.i18n',
87 - 'jquery.wikiEditor.toolbar', 'jquery.wikiEditor.dialogs',
88 - 'query.async', 'jquery.cookie')
89 -);
90 -
9184 // Hooks
9285 // Parser Function Setup
9386 $wgHooks['ParserFirstCallInit'][] = 'LqtHooks::onParserFirstCallInit';
Index: trunk/extensions/LiquidThreads/api/ApiThreadAction.php
@@ -821,6 +821,11 @@
822822
823823 $result = array( 'inlineeditform' => array( 'html' => $output ) );
824824
 825+ /* FIXME
 826+ $result['resources'] = LqtView::getJSandCSS();
 827+ $result['resources']['messages'] = LqtView::exportJSLocalisation();
 828+ */
 829+
825830 $this->getResult()->addValue( null, 'threadaction', $result );
826831 }
827832
Index: trunk/extensions/LiquidThreads/lqt.js
@@ -228,7 +228,10 @@
229229 liquidThreads.loadInlineEditForm( params, container,
230230 function() {
231231 if ( typeof mediaWiki.loader != 'undefined' && mediaWiki.loader ) {
232 - mediaWiki.loader.using( 'ext.liquidThreads.edit',
 232+ mediaWiki.loader.using(
 233+ [ 'ext.wikiEditor', 'ext.wikiEditor.toolbar.i18n',
 234+ 'jquery.wikiEditor.toolbar', 'jquery.wikiEditor.dialogs',
 235+ 'jquery.async', 'jquery.cookie' ],
233236 finishSetup );
234237 } else {
235238 finishSetup();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95631Follow up to r79941...hartman17:41, 28 August 2011

Status & tagging log