r96204 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96203‎ | r96204 | r96205 >
Date:16:30, 3 September 2011
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
workaround for IE bug - activex components like input fields coming on top of everything.
Modified paths:
  • /trunk/extensions/Narayam/js/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/js/ext.narayam.core.js
@@ -499,6 +499,15 @@
500500 $checkbox
501501 .attr( 'title', mw.msg( 'narayam-checkbox-tooltip' ) )
502502 .click( that.toggle );
 503+ //workaround for IE bug - activex components like input fields coming on top of everything.
 504+ //TODO: is there a better solution other than hiding it on hover?
 505+ if ( $.browser.msie ) {
 506+ $("#narayam-menu").hover(function(){
 507+ $("#searchform").css({ visibility: "hidden" });
 508+ },function(){
 509+ $("#searchform").css({ visibility: "visible" });
 510+ });
 511+ }
503512 }
504513
505514 } )();

Follow-up revisions

RevisionCommit summaryAuthorDate
r96573More style fixes, mostly for r96204catrope15:03, 8 September 2011
r96574Fix regression in r96204: IME was not turned on and icon not shown if you did...catrope15:03, 8 September 2011

Comments

#Comment by Catrope (talk | contribs)   15:28, 8 September 2011

Meh, this is kind of a lame way to do it but I don't know how else it would be done. I thought z-index would work but that doesn't help in IE7.

Maybe we can make the browser sniffing a bit more evil and only hide the search box in IE7 and below? That way the majority of IE users (IE8) aren't affected.

Status & tagging log