r96574 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96573‎ | r96574 | r96575 >
Date:15:03, 8 September 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix regression in r96204: IME was not turned on and icon not shown if you didn't have a cookie with the currently enabled scheme
Modified paths:
  • /trunk/extensions/Narayam/js/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/js/ext.narayam.core.js
@@ -439,7 +439,10 @@
440440 $( '#narayam-' + savedScheme ).attr( 'checked', 'checked' );
441441 } else {
442442 //if no saved input scheme, select the first.
443 - $( 'input.narayam-scheme:first' ).attr( 'checked', 'checked' );
 443+ var $firstScheme = $( 'input.narayam-scheme:first' );
 444+ that.setScheme( $firstScheme.val() );
 445+ $firstScheme.attr( 'checked', 'checked' );
 446+
444447 }
445448 var enabledCookie = $.cookie( 'narayam-enabled' );
446449 if ( enabledCookie == '1' || ( mw.config.get( 'wgNarayamEnabledByDefault' ) && enabledCookie !== '0' ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96204workaround for IE bug - activex components like input fields coming on top of...santhosh16:30, 3 September 2011

Status & tagging log