r96073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96072‎ | r96073 | r96074 >
Date:00:32, 2 September 2011
Author:kaldari
Status:reverted
Tags:
Comment:
failsafe for if they dont have the country value, e.g. didnt come from LandingCheck
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.body.php
@@ -199,7 +199,9 @@
200200 $newdata[ $value ] = substr( $data[ $value ], 0, 6 );
201201 break;
202202 case "country":
203 - $newdata[ $value ] = $country_codes[ $data[ $value ]];
 203+ if ( array_key_exists( $value, $data ) ) {
 204+ $newdata[ $value ] = $country_codes[ $data[ $value ]];
 205+ }
204206 break;
205207 default:
206208 $newdata[ $value ] = $data[ $value ];

Follow-up revisions

RevisionCommit summaryAuthorDate
r96076reverting r96073, according to arthur it should give a notice if country isnt...kaldari00:51, 2 September 2011

Status & tagging log