r96076 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96075‎ | r96076 | r96077 >
Date:00:51, 2 September 2011
Author:kaldari
Status:ok
Tags:
Comment:
reverting r96073, according to arthur it should give a notice if country isnt defined - since its important to minfraud
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.body.php
@@ -199,9 +199,7 @@
200200 $newdata[ $value ] = substr( $data[ $value ], 0, 6 );
201201 break;
202202 case "country":
203 - if ( array_key_exists( $value, $data ) ) {
204 - $newdata[ $value ] = $country_codes[ $data[ $value ]];
205 - }
 203+ $newdata[ $value ] = $country_codes[ $data[ $value ]];
206204 break;
207205 default:
208206 $newdata[ $value ] = $data[ $value ];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96073failsafe for if they dont have the country value, e.g. didnt come from Landin...kaldari00:32, 2 September 2011

Status & tagging log