r95969 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95968‎ | r95969 | r95970 >
Date:12:17, 1 September 2011
Author:siebrand
Status:ok
Tags:
Comment:
Fix incorrect button text on Special:BannerAllocation.
Update translator documentation for 'centralnotice-modify'.
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php
@@ -117,7 +117,7 @@
118118
119119 $htmlOut .= Xml::tags( 'div',
120120 array( 'class' => 'cn-buttons' ),
121 - Xml::submitButton( wfMsg( 'centralnotice-modify' ) )
 121+ Xml::submitButton( wfMsg( 'centralnotice-view' ) )
122122 );
123123 $htmlOut .= Html::closeElement( 'form' );
124124
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -24,6 +24,7 @@
2525 'centralnotice-end-date' => 'End date',
2626 'centralnotice-enabled' => 'Enabled',
2727 'centralnotice-modify' => 'Submit',
 28+ 'centralnotice-view' => 'View',
2829 'centralnotice-save-banner' => 'Save banner',
2930 'centralnotice-preview' => 'Preview',
3031 'centralnotice-nopreview' => '(Preview not available)',
@@ -204,11 +205,12 @@
205206 'centralnotice-end-date' => '{{Identical|End date}}',
206207 'centralnotice-enabled' => '{{Identical|Enabled}}',
207208 'centralnotice-modify' => 'Submit button on:
208 -* "change translation language" dialog box on [[m:Special:NoticeTemplate]]
209 -* "view banner allocation" on [[m:Special:BannerAllocation]]
210 -* any others?
 209+* "change translation language" dialog box on [[m:Special:NoticeTemplate]].
 210+* "add campaign" form on [[m:Special:CentralNotice]] (only when sufficent access rights).
211211
212212 {{Identical|Submit}}',
 213+ 'centralnotice-view' => 'Submit button on:
 214+* "view banner allocation" on [[m:Special:BannerAllocation]].',
213215 'centralnotice-save-banner' => 'Label for the submit button which saves a CentralNotice banner.',
214216 'centralnotice-preview' => '{{Identical|Preview}}',
215217 'centralnotice-nopreview' => '{{Identical|Nopreview}}',

Follow-up revisions

RevisionCommit summaryAuthorDate
r98902MFT r95697, r95912, r95966, r95967, r95969awjrichards20:39, 4 October 2011

Status & tagging log