r95912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95911‎ | r95912 | r95913 >
Date:22:09, 31 August 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:fundraising 
Comment:
Converted spaces to tabs, removed third parameter from $wgRequest->getText(). See bug #30271
Modified paths:
  • /trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php
@@ -23,15 +23,15 @@
2424
2525 $locationSubmitted = false;
2626
27 - $this->project = $wgRequest->getText( 'project', 'wikipedia', $wgNoticeProject );
28 - $this->language = $wgRequest->getText( 'language', $wgLanguageCode );
 27+ $this->project = $wgRequest->getText( 'project', $wgNoticeProject );
 28+ $this->language = $wgRequest->getText( 'language', $wgLanguageCode );
2929
30 - // If the form has been submitted, the country code should be passed along.
31 - $locationSubmitted = $wgRequest->getVal( 'country' );
32 - $this->location = $locationSubmitted ? $locationSubmitted : $this->location;
 30+ // If the form has been submitted, the country code should be passed along.
 31+ $locationSubmitted = $wgRequest->getVal( 'country' );
 32+ $this->location = $locationSubmitted ? $locationSubmitted : $this->location;
3333
34 - // Convert submitted location to boolean value. If it true, showList() will be called.
35 - $locationSubmitted = (boolean) $locationSubmitted;
 34+ // Convert submitted location to boolean value. If it true, showList() will be called.
 35+ $locationSubmitted = (boolean) $locationSubmitted;
3636
3737 // Begin output
3838 $this->setHeaders();

Follow-up revisions

RevisionCommit summaryAuthorDate
r98902MFT r95697, r95912, r95966, r95967, r95969awjrichards20:39, 4 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95697Switched BannerAllocation form from post to get. See bug 30271.jpostlethwaite21:05, 29 August 2011

Comments

#Comment by Kaldari (talk | contribs)   18:16, 23 September 2011

Looks like the issues are fixed.

Status & tagging log