r95959 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95958‎ | r95959 | r95960 >
Date:10:35, 1 September 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Followup r95957, add =null to Skin::outputPage too
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -282,7 +282,7 @@
283283 * Outputs the HTML generated by other functions.
284284 * @param $out OutputPage
285285 */
286 - abstract function outputPage( OutputPage $out );
 286+ abstract function outputPage( OutputPage $out=null );
287287
288288 static function makeVariablesScript( $data ) {
289289 if ( $data ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r95990A d d s p a c e sdemon14:33, 1 September 2011
r112296Updates for r95957/r95959, committing for test on servertstarling03:53, 24 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95957Kill off use of $wgRequest, $wgUser, and $wgLang in SkinTemplate, stop using ...dantman10:24, 1 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   14:31, 1 September 2011

wants more spaces around =. :)

#Comment by Platonides (talk | contribs)   15:49, 1 September 2011

This breaks existing skins Fatal error: Declaration of SkinNAME::outputPage() must be compatible with that of Skin::outputPage()

#Comment by Dantman (talk | contribs)   17:27, 1 September 2011

What kind of skin is declaring a SkinName::outputPage? That's an entrypoint controlling nearly the entire implementation of the skin system, skins shouldn't be overloading that method, only implementations of entirely new skin systems like SkinTemplate.

#Comment by Platonides (talk | contribs)   20:51, 3 September 2011

I had used it on a custom skin. I used that point just to call $out->setPageTitle() and $out->setHTMLTitle(), before calling the normal outputPage()

#Comment by Dantman (talk | contribs)   22:41, 3 September 2011

initPage, which IS a method meant for skins to override should be usable for that purpose.

#Comment by Platonides (talk | contribs)   15:39, 5 September 2011

Ok. I hope /that/ is not broken later.

#Comment by Tim Starling (talk | contribs)   03:49, 24 February 2012

This broke wikimediafoundation.org.

Status & tagging log