r112296 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112295‎ | r112296 | r112297 >
Date:03:53, 24 February 2012
Author:tstarling
Status:ok
Tags:
Comment:
Updates for r95957/r95959, committing for test on server
Modified paths:
  • /trunk/extensions/skins/Donate/Donate.class.php (modified) (history)
  • /trunk/extensions/skins/Schulenburg/Schulenburg.class.php (modified) (history)
  • /trunk/extensions/skins/Tomas/Tomas.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/skins/Schulenburg/Schulenburg.class.php
@@ -11,8 +11,14 @@
1212 return "{$this->path}/main.js";
1313 }
1414
15 - function outputPage( OutputPage $out ) {
 15+ function outputPage( OutputPage $out = null ) {
1616 global $wgContLang, $wgSchulenburgSkinPath, $wgScriptPath;
 17+
 18+ if ( !$out ) {
 19+ // MW 1.19
 20+ $out = $this->getOutput();
 21+ }
 22+
1723 $lang = $wgContLang->getCode();
1824 $this->path = $wgSchulenburgSkinPath ? $wgSchulenburgSkinPath : "{$wgScriptPath}/extensions/skins/Schulenburg";
1925 $this->out = $out;
Index: trunk/extensions/skins/Tomas/Tomas.class.php
@@ -11,8 +11,14 @@
1212 return "{$this->path}/main.js";
1313 }
1414
15 - function outputPage( OutputPage $out ) {
 15+ function outputPage( OutputPage $out = null ) {
1616 global $wgContLang, $wgTomasSkinPath, $wgScriptPath;
 17+
 18+ if ( !$out ) {
 19+ // MW 1.19
 20+ $out = $this->getOutput();
 21+ }
 22+
1723 $lang = $wgContLang->getCode();
1824 $this->path = $wgTomasSkinPath ? $wgTomasSkinPath : "{$wgScriptPath}/extensions/skins/Tomas";
1925 $this->out = $out;
Index: trunk/extensions/skins/Donate/Donate.class.php
@@ -11,8 +11,14 @@
1212 return "{$this->path}/main.js";
1313 }
1414
15 - function outputPage( OutputPage $out ) {
 15+ function outputPage( OutputPage $out = null ) {
1616 global $wgContLang, $wgDonateSkinPath, $wgScriptPath;
 17+
 18+ if ( !$out ) {
 19+ // MW 1.19
 20+ $out = $this->getOutput();
 21+ }
 22+
1723 $lang = $wgContLang->getCode();
1824 $this->path = $wgDonateSkinPath ? $wgDonateSkinPath : "{$wgScriptPath}/extensions/skins/Donate";
1925 $this->out = $out;

Follow-up revisions

RevisionCommit summaryAuthorDate
r112297MFT r112296: fixes for 1.19 compatibilitytstarling03:54, 24 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95957Kill off use of $wgRequest, $wgUser, and $wgLang in SkinTemplate, stop using ...dantman10:24, 1 September 2011
r95959Followup r95957, add =null to Skin::outputPage toodantman10:35, 1 September 2011

Status & tagging log