r95903 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95902‎ | r95903 | r95904 >
Date:19:22, 31 August 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.17wmf1: MFT r95894 for real this time, followup r95901
Modified paths:
  • /branches/wmf/1.17wmf1/includes/User.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/User.php
@@ -3034,7 +3034,7 @@
30353035
30363036 /**
30373037 * Internal function to format the e-mail validation/invalidation URLs.
3038 - * This uses $wgArticlePath directly as a quickie hack to use the
 3038+ * This uses a quickie hack to use the
30393039 * hardcoded English names of the Special: pages, for ASCII safety.
30403040 *
30413041 * @note Since these URLs get dropped directly into emails, using the
@@ -3047,14 +3047,9 @@
30483048 * @return \string Formatted URL
30493049 */
30503050 protected function getTokenUrl( $page, $token ) {
3051 - global $wgCanonicalServer, $wgArticlePath;
3052 -
3053 - return $wgCanonicalServer .
3054 - str_replace(
3055 - '$1',
3056 - "Special:$page/$token",
3057 - $wgArticlePath
3058 - );
 3051+ // Hack to bypass localization of 'Special:'
 3052+ $title = Title::makeTitle( NS_MAIN, "Special:$page/$token" );
 3053+ return $title->getCanonicalUrl();
30593054 }
30603055
30613056 /**
Property changes on: branches/wmf/1.17wmf1/includes/User.php
___________________________________________________________________
Modified: svn:mergeinfo
30623057 Merged /trunk/phase3/includes/User.php:r95894

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95894Followup r95002: unbreak getTokenUrl() by using a simpler hack that doesn't i...catrope18:08, 31 August 2011
r959011.17wmf1: MFT HTTPS / prot rel URL fixes: r95627, r95651, r95652, r95653, r95...catrope19:15, 31 August 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   19:24, 31 August 2011

Merge looks good.

Status & tagging log