r95426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95425‎ | r95426 | r95427 >
Date:19:52, 24 August 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix testGetTalkExceptions from r82577
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/MWNamespaceTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/MWNamespaceTest.php
@@ -86,11 +86,19 @@
8787
8888 /**
8989 * Exceptions with getTalk()
90 - * NS_MEDIA and NS_SPECIAL do not have talk pages. MediaWiki raise an exception for them.
 90+ * NS_MEDIA does not have talk pages. MediaWiki raise an exception for them.
9191 * @expectedException MWException
9292 */
93 - public function testGetTalkExceptions() {
 93+ public function testGetTalkExceptionsForNsMedia() {
9494 $this->assertNull( MWNamespace::getTalk( NS_MEDIA ) );
 95+ }
 96+
 97+ /**
 98+ * Exceptions with getTalk()
 99+ * NS_SPECIAL does not have talk pages. MediaWiki raise an exception for them.
 100+ * @expectedException MWException
 101+ */
 102+ public function testGetTalkExceptionsForNsSpecial() {
95103 $this->assertNull( MWNamespace::getTalk( NS_SPECIAL ) );
96104 }
97105
@@ -114,6 +122,7 @@
115123 public function testGetAssociatedExceptionsForNsMedia() {
116124 $this->assertNull( MWNamespace::getAssociated( NS_MEDIA ) );
117125 }
 126+
118127 /**
119128 * @expectedException MWException
120129 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r95632MFT to REL1_18...hashar17:57, 28 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82577improve namespace related methods...hashar22:17, 21 February 2011

Comments

#Comment by Hashar (talk | contribs)   19:57, 24 August 2011

thanks!

Status & tagging log