r95425 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95424‎ | r95425 | r95426 >
Date:19:48, 24 August 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Revert r95408, breaks preferences
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
@@ -695,8 +695,9 @@
696696 : $value->getDefault();
697697 $tableHtml .= $value->getTableRow( $v );
698698
699 - if ( $value->getLabel() != ' ' )
 699+ if ( $value->getLabel() != ' ' ) {
700700 $hasLeftColumn = true;
 701+ }
701702 } elseif ( is_array( $value ) ) {
702703 $section = $this->displaySection( $value, $key );
703704 $legend = $this->getLegend( $key );
@@ -708,7 +709,7 @@
709710 }
710711 $attributes = array();
711712 if ( $displayTitle ) {
712 - $attributes["title"] = Sanitizer::escapeId( $key );
 713+ $attributes["id"] = 'prefsection-' . Sanitizer::escapeId( $key, 'noninitial' );
713714 }
714715 $subsectionHtml .= Xml::fieldset( $legend, $section, $attributes ) . "\n";
715716 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95408Revert changes to HTMLForm from r92155reedy18:11, 24 August 2011

Comments

#Comment by Reedy (talk | contribs)   21:42, 24 August 2011

Yay, commit 3,000

Status & tagging log