r94763 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94762‎ | r94763 | r94764 >
Date:14:19, 17 August 2011
Author:dantman
Status:resolved
Tags:
Comment:
Followup fixme for r85302; Removing the wfDeprecated call from new OutputPage in REL1_18 where RequestContext was first introduced.
Editing the branch since we want the deprecated call in 1.19 which is in trunk.
Modified paths:
  • /branches/REL1_18/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/OutputPage.php
——@@ -1,3 +1,4 @@
 2+
23 <?php
34 if ( !defined( 'MEDIAWIKI' ) ) {
45 die( 1 );
——@@ -226,10 +227,6 @@
227228 * a OutputPage tied to that context.
228229 */
229230 function __construct( RequestContext $context = null ) {
230 - if ( !isset($context) ) {
231 - # Extensions should use `new RequestContext` instead of `new OutputPage` now.
232 - wfDeprecated( __METHOD__ );
233 - }
234231 $this->mContext = $context;
235232 }
236233

Follow-up revisions

RevisionCommit summaryAuthorDate
r955031.18: partial revert of r94763 -- no extra crap before the PHP starting tag, ...ashley19:14, 25 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85302Instead of creating an OutputPage and then setting a context start initializi...dantman00:37, 4 April 2011

Status & tagging log