r94509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94508‎ | r94509 | r94510 >
Date:13:06, 15 August 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r94404: remove LOCK IN SHARE MODE because locking reads are evil, per Tim. Will implement a better solution to prevent counter drift without locking reads, but that involves changing the DB schema a bit so I want to discuss that with Howie and Dario first
Modified paths:
  • /trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php
——@@ -56,7 +56,6 @@
5757 array(
5858 'ORDER BY' => 'aa_revision DESC',
5959 'LIMIT' => count( $wgArticleFeedbackRatings ),
60 - 'LOCK IN SHARE MODE', // Prevent race conditions
6160 )
6261 );
6362
——@@ -456,4 +455,4 @@
457456 public function getVersion() {
458457 return __CLASS__ . ': $Id$';
459458 }
460 -}
\ No newline at end of file
 459+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r945621.17wmf1: MFT r93711, r94346, r94369, r94376, r94404, r94502, r94509, r94511catrope20:30, 15 August 2011
r95628MFT to REL1_18 (extensions)...hashar15:32, 28 August 2011
r96722Epic followup to r94404, r94509: change the ArticleFeedback schema such that ...catrope15:26, 10 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94404Hopefully prevent race conditions in ArticleFeedback by reading from the mast...catrope10:46, 13 August 2011

Status & tagging log