r93711 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93710‎ | r93711 | r93712 >
Date:08:35, 2 August 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 30178) Narayam input manager: switch 'ta' as default before 'ta99' for Tamil

Using explicit dependency order in addition to reordering the entries.
Modified paths:
  • /trunk/extensions/Narayam/Narayam.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/Narayam.php
——@@ -221,16 +221,16 @@
222222 'messages' => array( 'narayam-si-wijesekara' ),
223223 'dependencies' => 'ext.narayam.core',
224224 );
225 -$wgResourceModules['ext.narayam.rules.ta99'] = $narayamTpl + array(
226 - 'scripts' => 'ext.narayam.rules.ta99.js',
227 - 'messages' => array( 'narayam-ta99' ),
228 - 'dependencies' => 'ext.narayam.core',
229 -);
230225 $wgResourceModules['ext.narayam.rules.ta'] = $narayamTpl + array(
231226 'scripts' => 'ext.narayam.rules.ta.js',
232227 'messages' => array( 'narayam-ta' ),
233228 'dependencies' => 'ext.narayam.core',
234229 );
 230+$wgResourceModules['ext.narayam.rules.ta99'] = $narayamTpl + array(
 231+ 'scripts' => 'ext.narayam.rules.ta99.js',
 232+ 'messages' => array( 'narayam-ta99' ),
 233+ 'dependencies' => 'ext.narayam.rules.ta', // make sure ta99 loads after ta
 234+);
235235 $wgResourceModules['ext.narayam.rules.te-inscript'] = $narayamTpl + array(
236236 'scripts' => 'ext.narayam.rules.te-inscript.js',
237237 'messages' => array( 'narayam-te-inscript' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r945621.17wmf1: MFT r93711, r94346, r94369, r94376, r94404, r94502, r94509, r94511catrope20:30, 15 August 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   08:36, 2 August 2011

Suppose this needs merge to 1.17wmf1 for deployment?

#Comment by Junaidpv (talk | contribs)   10:18, 2 August 2011

We should add some provision to configure in LocalSettings.php to change the order of schemes in the list.

Status & tagging log