r94491 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94490‎ | r94491 | r94492 >
Date:06:17, 15 August 2011
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Remove fixme note since hashar fixed it in r94409.
Modified paths:
  • /trunk/php/luasandbox/config.m4 (modified) (history)

Diff [purge]

Index: trunk/php/luasandbox/config.m4
@@ -4,12 +4,6 @@
55 PHP_ARG_WITH(luasandbox, for luasandbox support,
66 [ --with-luasandbox Include luasandbox support])
77
8 -dnl TODO: make this find either lua or luajit as it is installed in various
9 -dnl distros. Make a define available to C to indicate luajit is available
10 -dnl as opposed to lua. Maybe use pkgconfig since the library file is in an
11 -dnl odd place. Allow the user to specify the include directory manually.
12 -dnl -- TS
13 -
148 if test "$PHP_LUASANDBOX" != "no"; then
159 dnl Include pkg-config macros definitions:
1610 m4_include([m4/pkg.m4])

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94409use pkg-config macros to find luahashar14:31, 13 August 2011

Comments

#Comment by Hashar (talk | contribs)   10:27, 15 August 2011

Which probably means my pkg-config macros works for you :-)

Status & tagging log