r94492 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94491‎ | r94492 | r94493 >
Date:06:23, 15 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
moved the 'format as' select-box to below printouts
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php
@@ -1487,7 +1487,7 @@
14881488 }
14891489
14901490 $result[0] .= "</select>";
1491 - $result[0] .= "</p>\n";
 1491+ $result[0] .= "\n";
14921492 $result[] .= '<fieldset><legend>' . wfMsg( 'smw_ask_otheroptions' ) . "</legend>\n";
14931493 $result[1] .= "<div id=\"other_options\">" . $this->showFormatOptions( $params['format'], $params ) . " </div>";
14941494 $result[1] .= "</fieldset>\n";
Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -41,7 +41,7 @@
4242 );
4343 }
4444
45 - $htmlOutput .= Html::rawElement( 'div', array( 'class' => 'smw-qc-result' ), $this->uiCore->getHTMLResult() );
 45+ $htmlOutput .= Html::rawElement( 'div', array( 'class' => 'smwqcresult' ), $this->uiCore->getHTMLResult() );
4646
4747 if ( $this->usesNavigationBar() ) {
4848 $htmlOutput .= Html::rawElement( 'div', array( 'class' => 'smwqcnavbar' ),
@@ -82,17 +82,16 @@
8383 $formatBox = $this->getFormatSelectBoxSep( 'broadtable' );
8484 $result .= '<form name="ask" action="' . $specTitle->escapeLocalURL() . '" method="get">' . "\n" .
8585 '<input type="hidden" name="title" value="' . $specTitle->getPrefixedText() . '"/>';
86 - $result .= '<br>';
 86+ $result .= '<br/>';
8787 $result .= wfMsg( 'smw_qc_query_help' );
8888 // Main query and format options
89 - $result .= '<table style="width: 100%; ">' .
90 - '<tr><th>' . wfMsg( 'smw_ask_queryhead' ) . "</th>\n<th>" . wfMsg( 'smw_ask_format_as' ) . "</th></tr>" .
91 - '<tr>' .
92 - '<td style="width: 70%; padding-right: 7px;">' . $this->getQueryFormBox() . "</td>\n" .
93 - '<td style="padding-right: 7px; text-align:center;">' . $formatBox[0];
94 -
 89+ $result .= $this->getQueryFormBox();
 90+ // sorting and prinouts
 91+ $result .= '<div class="smw-qc-sortbox" style="padding-left:10px;">' . $this->getPoSortFormBox() . '</div>';
 92+ // additional options
9593 //START: show|hide additional options
96 - $result .= '<span id="show_additional_options" style="display:inline;"><a href="#addtional" rel="nofollow" onclick="' .
 94+ $result .= '<div class="smwqcformatas"><strong>'.wfMsg('smw_ask_format_as').'</strong>';
 95+ $result .= $formatBox[0].'<span id="show_additional_options" style="display:inline;"><a href="#addtional" rel="nofollow" onclick="' .
9796 "jQuery('#additional_options').show('blind');" .
9897 "document.getElementById('show_additional_options').style.display='none';" .
9998 "document.getElementById('hide_additional_options').style.display='inline';" . '">' .
@@ -102,14 +101,8 @@
103102 "document.getElementById('hide_additional_options').style.display='none';" .
104103 "document.getElementById('show_additional_options').style.display='inline';" . '">' .
105104 wfMsg( 'smw_qc_hide_addnal_opts' ) . '</a></span>';
 105+ $result .= '</div>';
106106 //END: show|hide additional options
107 -
108 - $result .= '</td>' .
109 - '</tr>' .
110 - "</table>\n";
111 - // sorting and prinouts
112 - $result .= '<div class="smw-qc-sortbox" style="padding-left:10px;">' . $this->getPoSortFormBox() . '</div>';
113 - // additional options
114107 $result .= '<div id="additional_options" style="display:none">';
115108
116109 $result .= $formatBox[1]; // display the format options
@@ -119,7 +112,7 @@
120113
121114 $result .= '<a href="' . htmlspecialchars( wfMsg( 'smw_ask_doculink' ) ) . '">' . wfMsg( 'smw_ask_help' ) . '</a>';
122115 if ( $this->uiCore->getQueryString() != '' ) { // hide #ask if there isnt any query defined
123 - $result .= ' | <a name="show-embed-code" id="show-embed-code" href="##">' . wfMsg( 'smw_ask_show_embed' ) . '</a>';
 116+ $result .= ' | <a name="show-embed-code" id="show-embed-code" href="##" rel="nofollow">' . wfMsg( 'smw_ask_show_embed' ) . '</a>';
124117 $result .= '<div id="embed-code-dialog">' .
125118 $this->getAskEmbedBox() .
126119 '</div>';
Index: trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css
@@ -160,6 +160,11 @@
161161 padding-top: 5px;
162162 }
163163
 164+div.smwqcformatas{
 165+ margin:10px;
 166+ margin-top: 15px;
 167+ margin-bottom: 0px;
 168+}
164169 /* search, browse, RDF icons */
165170
166171 span.smwsearchicon { /*FIXME: this was only used for Factbox docu, should be removed from code*/