r93916 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93915‎ | r93916 | r93917 >
Date:21:04, 4 August 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Self-revert r91453: not a well thought out addition to the EditPage::showEditForm:initial hook
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -741,7 +741,6 @@
742742
743743 'EditPage::showEditForm:initial': before showing the edit form
744744 $editor: EditPage instance (object)
745 -$formCallback: Array for callback of modifying the edit form
746745
747746 Return false to halt editing; you'll need to handle error messages, etc.
748747 yourself. Alternatively, modifying $error and returning true will cause the
Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -185,8 +185,6 @@
186186 the relevant section of the category.
187187 * (bug 29109) Allow the automatic edit summary for redirect creation
188188 show the first bit of the new redirect page.
189 -* (bug 5800) Added $formCallback as a parameter to the hook
190 - EditPage::showEditForm:initial.
191189 * (bug 29723) mw.util.wikiGetlink() now defaults to wgPageName.
192190 * (bug 29680) Add GetDefaultSortkey hook to override the default sortkey.
193191 * (bug 16699) {{#language:}} accepts second parameter to specify the language in
Index: trunk/phase3/includes/EditPage.php
@@ -1330,7 +1330,7 @@
13311331 $previewOutput = $this->getPreviewText();
13321332 }
13331333
1334 - wfRunHooks( 'EditPage::showEditForm:initial', array( &$this, &$formCallback ) );
 1334+ wfRunHooks( 'EditPage::showEditForm:initial', array( &$this ) );
13351335
13361336 $this->setHeaders();
13371337

Follow-up revisions

RevisionCommit summaryAuthorDate
r93917MFT r93916demon21:09, 4 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91453(bug 5800) Added $formCallback as a parameter to the hook EditPage::showEditF...demon12:48, 5 July 2011

Comments

#Comment by 😂 (talk | contribs)   21:56, 4 August 2011

Whoops, didn't mean to set this reverted. Can someone set back to ok, thanks :)

Status & tagging log