r93917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93916‎ | r93917 | r93918 >
Date:21:09, 4 August 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r93916
Modified paths:
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/docs/hooks.txt (modified) (history)
  • /branches/REL1_18/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/docs/hooks.txt
@@ -730,7 +730,6 @@
731731
732732 'EditPage::showEditForm:initial': before showing the edit form
733733 $editor: EditPage instance (object)
734 -$formCallback: Array for callback of modifying the edit form
735734
736735 Return false to halt editing; you'll need to handle error messages, etc.
737736 yourself. Alternatively, modifying $error and returning true will cause the
Property changes on: branches/REL1_18/phase3/docs/hooks.txt
___________________________________________________________________
Added: svn:mergeinfo
738737 Merged /branches/new-installer/phase3/docs/hooks.txt:r43664-66004
739738 Merged /branches/REL1_15/phase3/docs/hooks.txt:r51646
740739 Merged /branches/REL1_17/phase3/docs/hooks.txt:r81445,81448
741740 Merged /branches/sqlite/docs/hooks.txt:r58211-58321
742741 Merged /trunk/phase3/docs/hooks.txt:r92634,92762,92791,92854,92958,93141,93303,93520,93916
Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
@@ -181,8 +181,6 @@
182182 the relevant section of the category.
183183 * (bug 29109) Allow the automatic edit summary for redirect creation
184184 show the first bit of the new redirect page.
185 -* (bug 5800) Added $formCallback as a parameter to the hook
186 - EditPage::showEditForm:initial.
187185 * (bug 29723) mw.util.wikiGetlink() now defaults to wgPageName.
188186 * (bug 29680) Add GetDefaultSortkey hook to override the default sortkey.
189187 * (bug 16699) {{#language:}} accepts second parameter to specify the language in
Property changes on: branches/REL1_18/phase3/RELEASE-NOTES-1.18
___________________________________________________________________
Added: svn:mergeinfo
190188 Merged /branches/sqlite/RELEASE-NOTES-1.18:r58211-58321
191189 Merged /trunk/phase3/RELEASE-NOTES-1.18:r92634,92762,92791,92854,92958,93141,93303,93520,93916
192190 Merged /branches/new-installer/phase3/RELEASE-NOTES-1.18:r43664-66004
193191 Merged /branches/REL1_15/phase3/RELEASE-NOTES-1.18:r51646
194192 Merged /branches/REL1_17/phase3/RELEASE-NOTES-1.18:r81445,81448
Index: branches/REL1_18/phase3/includes/EditPage.php
@@ -1333,7 +1333,7 @@
13341334 $previewOutput = $this->getPreviewText();
13351335 }
13361336
1337 - wfRunHooks( 'EditPage::showEditForm:initial', array( &$this, &$formCallback ) );
 1337+ wfRunHooks( 'EditPage::showEditForm:initial', array( &$this ) );
13381338
13391339 $this->setHeaders();
13401340
Property changes on: branches/REL1_18/phase3/includes/EditPage.php
___________________________________________________________________
Added: svn:mergeinfo
13411341 Merged /branches/sqlite/includes/EditPage.php:r58211-58321
13421342 Merged /trunk/phase3/includes/EditPage.php:r92634,92762,92791,92854,92958,93141,93303,93916
13431343 Merged /branches/new-installer/phase3/includes/EditPage.php:r43664-66004
13441344 Merged /branches/wmf-deployment/includes/EditPage.php:r53381
13451345 Merged /branches/REL1_15/phase3/includes/EditPage.php:r51646

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93916Self-revert r91453: not a well thought out addition to the EditPage::showEdit...demon21:04, 4 August 2011

Status & tagging log