r93560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93559‎ | r93560 | r93561 >
Date:23:31, 30 July 2011
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Per validation errors reported in #wikimedia-tech, urlencode the url
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/MobileFrontend/MobileFrontend.php
@@ -110,6 +110,7 @@
111111 $mobileViewUrl = $wgRequest->getRequestURL();
112112 $delimiter = ( strpos( $mobileViewUrl, "?" ) !== false ) ? "&" : "?";
113113 $mobileViewUrl .= $delimiter . 'useFormat=mobile';
 114+ $mobileViewUrl = urlencode( $mobileViewUrl );
114115
115116 $tpl->set('mobileview', "<a href='{$mobileViewUrl}'>Mobile View</a>");
116117 $footerlinks['places'][] = 'mobileview';

Follow-up revisions

RevisionCommit summaryAuthorDate
r93561htmlspecialchars() on urls outputted to pagesreedy00:00, 31 July 2011

Comments

#Comment by Catrope (talk | contribs)   20:45, 10 August 2011

old? Really?

#Comment by Reedy (talk | contribs)   21:01, 10 August 2011

Yup, it was superceeded very quickly after

So old is correct

Status & tagging log