r93559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93558‎ | r93559 | r93560 >
Date:20:27, 30 July 2011
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r93527: $value can also be null when not set
Modified paths:
  • /trunk/phase3/includes/specials/SpecialComparePages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialComparePages.php
@@ -130,7 +130,7 @@
131131 }
132132
133133 public function checkExistingTitle( $value, $alldata ) {
134 - if ( $value === '' ) {
 134+ if ( $value === '' || $value === null ) {
135135 return true;
136136 }
137137 $title = Title::newFromText( $value );
@@ -144,7 +144,7 @@
145145 }
146146
147147 public function checkExistingRevision( $value, $alldata ) {
148 - if ( $value === '' ) {
 148+ if ( $value === '' || $value === null ) {
149149 return true;
150150 }
151151 $revision = Revision::newFromId( $value );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93527In Special:ComparePages:...ialex15:03, 30 July 2011

Status & tagging log