r93388 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93387‎ | r93388 | r93389 >
Date:13:34, 28 July 2011
Author:robin
Status:reverted (Comments)
Tags:
Comment:
Follow-up r93386: fix editsection when user language direction != content lang dir
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -85,6 +85,7 @@
8686 /* Edit section links */
8787 .editsection {
8888 margin-left: 5px;
 89+ unicode-bidi: embed;
8990 }
9091 /**
9192 * File histories

Follow-up revisions

RevisionCommit summaryAuthorDate
r97746Revert r93388 because it was a fix for r93386 which was reverted.robin16:52, 21 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93386Redo r93284 ( Make editsection link more understandable by positioning it dir...diebuche12:26, 28 July 2011

Comments

#Comment by Amire80 (talk | contribs)   10:47, 21 September 2011

I'm not sure that i understand what is it for.

I tried it in a mixed-directionality environment and it seems to work correctly with and without this line. If i work in a Hebrew wiki with English interface and add a period to the word "edit", it appears on the wrong end even without this line. If i add "direction: ltr", then it appears correctly, and it works even without "unicode-bidi: embed".

#Comment by SPQRobin (talk | contribs)   16:50, 21 September 2011

Hmm, I'll revert this because it was a fix for r93386 which was reverted.

Status & tagging log