r93386 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93385‎ | r93386 | r93387 >
Date:12:26, 28 July 2011
Author:diebuche
Status:reverted (Comments)
Tags:
Comment:
Redo r93284 ( Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title ) in a more simple way and also include parserTests and release notes this time
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -84,12 +84,8 @@
8585
8686 /* Edit section links */
8787 .editsection {
88 - float: right;
8988 margin-left: 5px;
9089 }
91 -/* Correct directionality when page dir is different from site/user dir */
92 -/* @noflip */.mw-content-ltr .editsection, .mw-content-rtl .mw-content-ltr .editsection { float: right; }
93 -/* @noflip */.mw-content-rtl .editsection, .mw-content-ltr .mw-content-rtl .editsection { float: left; }
9490 /**
9591 * File histories
9692 */
Index: trunk/phase3/skins/vector/screen.css
——@@ -762,7 +762,6 @@
763763 h5 .editsection { font-weight: normal; }
764764 h6 { font-size: 80%; }
765765 h6 .editsection { font-size: 125%; font-weight: normal; }
766 -.editsection { float: right; }
767766 p {
768767 margin: .4em 0 .5em 0;
769768 line-height: 1.5em;
Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -29,6 +29,7 @@
3030 until the second was introduced in 1.17.
3131 * (bug 25355) Parser generates edit section links for special pages
3232 * (bug 13766) Change table of content syntax to be semantically correct
 33+* (bug 11270 & bug 11555) Make editsection link more understandable by positioning it next to the header.
3334
3435 === API changes in 1.19 ===
3536 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/tests/parser/parserTests.txt
——@@ -1813,7 +1813,7 @@
18141814 <table>
18151815 <tr valign="top">
18161816 <td>
1817 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Heading">edit</a>]</span> <span class="mw-headline" id="Heading"> Heading </span></h3>
 1817+<h3><span class="mw-headline" id="Heading"> Heading </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Heading">edit</a>]</span></h3>
18181818 </td>
18191819 </tr>
18201820 </table>
——@@ -3491,8 +3491,8 @@
34923492 !! input
34933493 {{includeonly section}}
34943494 !! result
3495 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Includeonly_section&amp;action=edit&amp;section=T-1" title="Template:Includeonly section">edit</a>]</span> <span class="mw-headline" id="Includeonly_section">Includeonly section</span></h2>
3496 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Includeonly_section&amp;action=edit&amp;section=T-2" title="Template:Includeonly section">edit</a>]</span> <span class="mw-headline" id="Section_T-1">Section T-1</span></h2>
 3495+<h2><span class="mw-headline" id="Includeonly_section">Includeonly section</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Includeonly_section&amp;action=edit&amp;section=T-1" title="Template:Includeonly section">edit</a>]</span></h2>
 3496+<h2><span class="mw-headline" id="Section_T-1">Section T-1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Includeonly_section&amp;action=edit&amp;section=T-2" title="Template:Includeonly section">edit</a>]</span></h2>
34973497
34983498 !! end
34993499
——@@ -3518,7 +3518,7 @@
35193519 </includeonly>
35203520 ==Section 1==
35213521 !! result
3522 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section 1">edit</a>]</span> <span class="mw-headline" id="Section_1">Section 1</span></h2>
 3522+<h2><span class="mw-headline" id="Section_1">Section 1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section 1">edit</a>]</span></h2>
35233523
35243524 !! end
35253525
——@@ -4537,13 +4537,13 @@
45384538 ===Smaller headline===
45394539 Blah blah
45404540 !! result
4541 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Headline 1">edit</a>]</span> <span class="mw-headline" id="Headline_1"> Headline 1 </span></h2>
 4541+<h2><span class="mw-headline" id="Headline_1"> Headline 1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Headline 1">edit</a>]</span></h2>
45424542 <p>Some text
45434543 </p>
4544 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Headline 2">edit</a>]</span> <span class="mw-headline" id="Headline_2">Headline 2</span></h2>
 4544+<h2><span class="mw-headline" id="Headline_2">Headline 2</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Headline 2">edit</a>]</span></h2>
45454545 <p>More
45464546 </p>
4547 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Smaller headline">edit</a>]</span> <span class="mw-headline" id="Smaller_headline">Smaller headline</span></h3>
 4547+<h3><span class="mw-headline" id="Smaller_headline">Smaller headline</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Smaller headline">edit</a>]</span></h3>
45484548 <p>Blah blah
45494549 </p>
45504550 !! end
——@@ -4582,14 +4582,14 @@
45834583 </li>
45844584 </ul>
45854585 </div>
4586 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Headline 1">edit</a>]</span> <span class="mw-headline" id="Headline_1"> Headline 1 </span></h2>
4587 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Subheadline 1">edit</a>]</span> <span class="mw-headline" id="Subheadline_1"> Subheadline 1 </span></h3>
4588 -<h5><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Skipping a level">edit</a>]</span> <span class="mw-headline" id="Skipping_a_level"> Skipping a level </span></h5>
4589 -<h6><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: Skipping a level">edit</a>]</span> <span class="mw-headline" id="Skipping_a_level_2"> Skipping a level </span></h6>
4590 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: Headline 2">edit</a>]</span> <span class="mw-headline" id="Headline_2"> Headline 2 </span></h2>
 4586+<h2><span class="mw-headline" id="Headline_1"> Headline 1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Headline 1">edit</a>]</span></h2>
 4587+<h3><span class="mw-headline" id="Subheadline_1"> Subheadline 1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Subheadline 1">edit</a>]</span></h3>
 4588+<h5><span class="mw-headline" id="Skipping_a_level"> Skipping a level </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Skipping a level">edit</a>]</span></h5>
 4589+<h6><span class="mw-headline" id="Skipping_a_level_2"> Skipping a level </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: Skipping a level">edit</a>]</span></h6>
 4590+<h2><span class="mw-headline" id="Headline_2"> Headline 2 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: Headline 2">edit</a>]</span></h2>
45914591 <p>Some text
45924592 </p>
4593 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: Another headline">edit</a>]</span> <span class="mw-headline" id="Another_headline">Another headline</span></h3>
 4593+<h3><span class="mw-headline" id="Another_headline">Another headline</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: Another headline">edit</a>]</span></h3>
45944594
45954595 !! end
45964596
——@@ -4637,16 +4637,16 @@
46384638 </li>
46394639 </ul>
46404640 </div>
4641 -<h1><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Level 1 Heading">edit</a>]</span> <span class="mw-headline" id="Level_1_Heading"> Level 1 Heading</span></h1>
4642 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Level 2 Heading">edit</a>]</span> <span class="mw-headline" id="Level_2_Heading"> Level 2 Heading</span></h2>
4643 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Level 3 Heading">edit</a>]</span> <span class="mw-headline" id="Level_3_Heading"> Level 3 Heading</span></h3>
4644 -<h4><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: Level 4 Heading">edit</a>]</span> <span class="mw-headline" id="Level_4_Heading"> Level 4 Heading</span></h4>
4645 -<h5><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: Level 5 Heading">edit</a>]</span> <span class="mw-headline" id="Level_5_Heading"> Level 5 Heading</span></h5>
4646 -<h6><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: Level 6 Heading">edit</a>]</span> <span class="mw-headline" id="Level_6_Heading"> Level 6 Heading</span></h6>
4647 -<h6><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=7" title="Edit section: = Level 7 Heading=">edit</a>]</span> <span class="mw-headline" id=".3D_Level_7_Heading.3D">= Level 7 Heading=</span></h6>
4648 -<h6><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=8" title="Edit section: == Level 8 Heading==">edit</a>]</span> <span class="mw-headline" id=".3D.3D_Level_8_Heading.3D.3D">== Level 8 Heading==</span></h6>
4649 -<h6><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=9" title="Edit section: === Level 9 Heading===">edit</a>]</span> <span class="mw-headline" id=".3D.3D.3D_Level_9_Heading.3D.3D.3D">=== Level 9 Heading===</span></h6>
4650 -<h6><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=10" title="Edit section: ==== Level 10 Heading====">edit</a>]</span> <span class="mw-headline" id=".3D.3D.3D.3D_Level_10_Heading.3D.3D.3D.3D">==== Level 10 Heading====</span></h6>
 4641+<h1><span class="mw-headline" id="Level_1_Heading"> Level 1 Heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Level 1 Heading">edit</a>]</span></h1>
 4642+<h2><span class="mw-headline" id="Level_2_Heading"> Level 2 Heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Level 2 Heading">edit</a>]</span></h2>
 4643+<h3><span class="mw-headline" id="Level_3_Heading"> Level 3 Heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Level 3 Heading">edit</a>]</span></h3>
 4644+<h4><span class="mw-headline" id="Level_4_Heading"> Level 4 Heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: Level 4 Heading">edit</a>]</span></h4>
 4645+<h5><span class="mw-headline" id="Level_5_Heading"> Level 5 Heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: Level 5 Heading">edit</a>]</span></h5>
 4646+<h6><span class="mw-headline" id="Level_6_Heading"> Level 6 Heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: Level 6 Heading">edit</a>]</span></h6>
 4647+<h6><span class="mw-headline" id=".3D_Level_7_Heading.3D">= Level 7 Heading=</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=7" title="Edit section: = Level 7 Heading=">edit</a>]</span></h6>
 4648+<h6><span class="mw-headline" id=".3D.3D_Level_8_Heading.3D.3D">== Level 8 Heading==</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=8" title="Edit section: == Level 8 Heading==">edit</a>]</span></h6>
 4649+<h6><span class="mw-headline" id=".3D.3D.3D_Level_9_Heading.3D.3D.3D">=== Level 9 Heading===</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=9" title="Edit section: === Level 9 Heading===">edit</a>]</span></h6>
 4650+<h6><span class="mw-headline" id=".3D.3D.3D.3D_Level_10_Heading.3D.3D.3D.3D">==== Level 10 Heading====</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=10" title="Edit section: ==== Level 10 Heading====">edit</a>]</span></h6>
46514651
46524652 !! end
46534653
——@@ -4679,12 +4679,12 @@
46804680 </li>
46814681 </ul>
46824682 </div>
4683 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: title 1">edit</a>]</span> <span class="mw-headline" id="title_1"> title 1 </span></h2>
4684 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: title 1.1">edit</a>]</span> <span class="mw-headline" id="title_1.1"> title 1.1 </span></h3>
4685 -<h4><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: title 1.1.1">edit</a>]</span> <span class="mw-headline" id="title_1.1.1"> title 1.1.1 </span></h4>
4686 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: title 1.2">edit</a>]</span> <span class="mw-headline" id="title_1.2"> title 1.2 </span></h3>
4687 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: title 2">edit</a>]</span> <span class="mw-headline" id="title_2"> title 2 </span></h2>
4688 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: title 2.1">edit</a>]</span> <span class="mw-headline" id="title_2.1"> title 2.1 </span></h3>
 4683+<h2><span class="mw-headline" id="title_1"> title 1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: title 1">edit</a>]</span></h2>
 4684+<h3><span class="mw-headline" id="title_1.1"> title 1.1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: title 1.1">edit</a>]</span></h3>
 4685+<h4><span class="mw-headline" id="title_1.1.1"> title 1.1.1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: title 1.1.1">edit</a>]</span></h4>
 4686+<h3><span class="mw-headline" id="title_1.2"> title 1.2 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: title 1.2">edit</a>]</span></h3>
 4687+<h2><span class="mw-headline" id="title_2"> title 2 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: title 2">edit</a>]</span></h2>
 4688+<h3><span class="mw-headline" id="title_2.1"> title 2.1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: title 2.1">edit</a>]</span></h3>
46894689
46904690 !! end
46914691
——@@ -4715,12 +4715,12 @@
47164716 </li>
47174717 </ul>
47184718 </div>
4719 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: title 1">edit</a>]</span> <span class="mw-headline" id="title_1"> title 1 </span></h2>
4720 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: title 1.1">edit</a>]</span> <span class="mw-headline" id="title_1.1"> title 1.1 </span></h3>
4721 -<h4><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: title 1.1.1">edit</a>]</span> <span class="mw-headline" id="title_1.1.1"> title 1.1.1 </span></h4>
4722 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: title 1.2">edit</a>]</span> <span class="mw-headline" id="title_1.2"> title 1.2 </span></h3>
4723 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: title 2">edit</a>]</span> <span class="mw-headline" id="title_2"> title 2 </span></h2>
4724 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: title 2.1">edit</a>]</span> <span class="mw-headline" id="title_2.1"> title 2.1 </span></h3>
 4719+<h2><span class="mw-headline" id="title_1"> title 1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: title 1">edit</a>]</span></h2>
 4720+<h3><span class="mw-headline" id="title_1.1"> title 1.1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: title 1.1">edit</a>]</span></h3>
 4721+<h4><span class="mw-headline" id="title_1.1.1"> title 1.1.1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: title 1.1.1">edit</a>]</span></h4>
 4722+<h3><span class="mw-headline" id="title_1.2"> title 1.2 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: title 1.2">edit</a>]</span></h3>
 4723+<h2><span class="mw-headline" id="title_2"> title 2 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: title 2">edit</a>]</span></h2>
 4724+<h3><span class="mw-headline" id="title_2.1"> title 2.1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: title 2.1">edit</a>]</span></h3>
47254725
47264726 !! end
47274727
——@@ -4745,11 +4745,11 @@
47464746 <li class="toclevel-1 tocsection-5"><a href="#Section_2"><span class="tocnumber">2</span> <span class="toctext">Section 2</span></a></li>
47474747 </ul>
47484748 </div>
4749 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section 1">edit</a>]</span> <span class="mw-headline" id="Section_1">Section 1</span></h2>
4750 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Section 1.1">edit</a>]</span> <span class="mw-headline" id="Section_1.1">Section 1.1</span></h3>
4751 -<h4><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Section 1.1.1">edit</a>]</span> <span class="mw-headline" id="Section_1.1.1">Section 1.1.1</span></h4>
4752 -<h4><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: Section 1.1.1.1">edit</a>]</span> <span class="mw-headline" id="Section_1.1.1.1">Section 1.1.1.1</span></h4>
4753 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: Section 2">edit</a>]</span> <span class="mw-headline" id="Section_2">Section 2</span></h2>
 4749+<h2><span class="mw-headline" id="Section_1">Section 1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section 1">edit</a>]</span></h2>
 4750+<h3><span class="mw-headline" id="Section_1.1">Section 1.1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Section 1.1">edit</a>]</span></h3>
 4751+<h4><span class="mw-headline" id="Section_1.1.1">Section 1.1.1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: Section 1.1.1">edit</a>]</span></h4>
 4752+<h4><span class="mw-headline" id="Section_1.1.1.1">Section 1.1.1.1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: Section 1.1.1.1">edit</a>]</span></h4>
 4753+<h2><span class="mw-headline" id="Section_2">Section 2</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: Section 2">edit</a>]</span></h2>
47544754
47554755 !! end
47564756
——@@ -4760,8 +4760,8 @@
47614761 == Foo bar ==
47624762 == Foo bar ==
47634763 !! result
4764 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Foo bar">edit</a>]</span> <span class="mw-headline" id="Foo_bar"> Foo bar </span></h2>
4765 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Foo bar">edit</a>]</span> <span class="mw-headline" id="Foo_bar_2"> Foo bar </span></h2>
 4764+<h2><span class="mw-headline" id="Foo_bar"> Foo bar </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Foo bar">edit</a>]</span></h2>
 4765+<h2><span class="mw-headline" id="Foo_bar_2"> Foo bar </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Foo bar">edit</a>]</span></h2>
47664766
47674767 !! end
47684768
——@@ -4771,8 +4771,8 @@
47724772 == Foo bar ==
47734773 == Foo Bar ==
47744774 !! result
4775 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Foo bar">edit</a>]</span> <span class="mw-headline" id="Foo_bar"> Foo bar </span></h2>
4776 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Foo Bar">edit</a>]</span> <span class="mw-headline" id="Foo_Bar_2"> Foo Bar </span></h2>
 4775+<h2><span class="mw-headline" id="Foo_bar"> Foo bar </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Foo bar">edit</a>]</span></h2>
 4776+<h2><span class="mw-headline" id="Foo_Bar_2"> Foo Bar </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Foo Bar">edit</a>]</span></h2>
47774777
47784778 !! end
47794779
——@@ -4791,10 +4791,10 @@
47924792 {{sections}}
47934793 ==Section 4==
47944794 !! result
4795 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section 0">edit</a>]</span> <span class="mw-headline" id="Section_0">Section 0</span></h2>
4796 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Sections&amp;action=edit&amp;section=T-1" title="Template:Sections">edit</a>]</span> <span class="mw-headline" id="Section_1">Section 1</span></h3>
4797 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Sections&amp;action=edit&amp;section=T-2" title="Template:Sections">edit</a>]</span> <span class="mw-headline" id="Section_2">Section 2</span></h2>
4798 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Section 4">edit</a>]</span> <span class="mw-headline" id="Section_4">Section 4</span></h2>
 4795+<h2><span class="mw-headline" id="Section_0">Section 0</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section 0">edit</a>]</span></h2>
 4796+<h3><span class="mw-headline" id="Section_1">Section 1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Sections&amp;action=edit&amp;section=T-1" title="Template:Sections">edit</a>]</span></h3>
 4797+<h2><span class="mw-headline" id="Section_2">Section 2</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Template:Sections&amp;action=edit&amp;section=T-2" title="Template:Sections">edit</a>]</span></h2>
 4798+<h2><span class="mw-headline" id="Section_4">Section 4</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: Section 4">edit</a>]</span></h2>
47994799
48004800 !! end
48014801
——@@ -4805,8 +4805,8 @@
48064806 ==Section 1==
48074807 ==Section 2==
48084808 !! result
4809 -<h2> <span class="mw-headline" id="Section_1">Section 1</span></h2>
4810 -<h2> <span class="mw-headline" id="Section_2">Section 2</span></h2>
 4809+<h2><span class="mw-headline" id="Section_1">Section 1</span> </h2>
 4810+<h2><span class="mw-headline" id="Section_2">Section 2</span> </h2>
48114811
48124812 !! end
48134813
——@@ -4815,7 +4815,7 @@
48164816 !! input
48174817 ==Section with a [[Main Page|link]] in it==
48184818 !! result
4819 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section with a link in it">edit</a>]</span> <span class="mw-headline" id="Section_with_a_link_in_it">Section with a <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">link</a> in it</span></h2>
 4819+<h2><span class="mw-headline" id="Section_with_a_link_in_it">Section with a <a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">link</a> in it</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: Section with a link in it">edit</a>]</span></h2>
48204820
48214821 !! end
48224822
——@@ -4837,9 +4837,9 @@
48384838 <li class="toclevel-1 tocsection-3"><a href="#title_2"><span class="tocnumber">2</span> <span class="toctext">title 2</span></a></li>
48394839 </ul>
48404840 </div>
4841 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: title 1">edit</a>]</span> <span class="mw-headline" id="title_1"> title 1 </span></h2>
4842 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: title 1.1">edit</a>]</span> <span class="mw-headline" id="title_1.1"> title 1.1 </span></h3>
4843 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: title 2">edit</a>]</span> <span class="mw-headline" id="title_2"> title 2 </span></h2>
 4841+<h2><span class="mw-headline" id="title_1"> title 1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: title 1">edit</a>]</span></h2>
 4842+<h3><span class="mw-headline" id="title_1.1"> title 1.1 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: title 1.1">edit</a>]</span></h3>
 4843+<h2><span class="mw-headline" id="title_2"> title 2 </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: title 2">edit</a>]</span></h2>
48444844
48454845 !! end
48464846
——@@ -4861,10 +4861,10 @@
48624862 --> <!-- -->
48634863 But just in case it doesn't...
48644864 !! result
4865 -<h1><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: =">edit</a>]</span> <span class="mw-headline" id=".3D">=</span></h1>
 4865+<h1><span class="mw-headline" id=".3D">=</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: =">edit</a>]</span></h1>
48664866 <p>The line above must have a trailing space!
48674867 </p>
4868 -<h1><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: =">edit</a>]</span> <span class="mw-headline" id=".3D_2">=</span></h1>
 4868+<h1><span class="mw-headline" id=".3D_2">=</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: =">edit</a>]</span></h1>
48694869 <p>But just in case it doesn't...
48704870 </p>
48714871 !! end
——@@ -4900,19 +4900,19 @@
49014901 <li class="toclevel-1 tocsection-5"><a href="#text_.22_text"><span class="tocnumber">5</span> <span class="toctext">text " text</span></a></li>
49024902 </ul>
49034903 </div>
4904 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: text > text">edit</a>]</span> <span class="mw-headline" id="text_.3E_text"> text &gt; text </span></h2>
 4904+<h2><span class="mw-headline" id="text_.3E_text"> text &gt; text </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: text > text">edit</a>]</span></h2>
49054905 <p>section 1
49064906 </p>
4907 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: text &lt; text">edit</a>]</span> <span class="mw-headline" id="text_.3C_text"> text &lt; text </span></h2>
 4907+<h2><span class="mw-headline" id="text_.3C_text"> text &lt; text </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: text &lt; text">edit</a>]</span></h2>
49084908 <p>section 2
49094909 </p>
4910 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: text &amp; text">edit</a>]</span> <span class="mw-headline" id="text_.26_text"> text &amp; text </span></h2>
 4910+<h2><span class="mw-headline" id="text_.26_text"> text &amp; text </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: text &amp; text">edit</a>]</span></h2>
49114911 <p>section 3
49124912 </p>
4913 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: text ' text">edit</a>]</span> <span class="mw-headline" id="text_.27_text"> text ' text </span></h2>
 4913+<h2><span class="mw-headline" id="text_.27_text"> text ' text </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: text ' text">edit</a>]</span></h2>
49144914 <p>section 4
49154915 </p>
4916 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: text &quot; text">edit</a>]</span> <span class="mw-headline" id="text_.22_text"> text " text </span></h2>
 4916+<h2><span class="mw-headline" id="text_.22_text"> text " text </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: text &quot; text">edit</a>]</span></h2>
49174917 <p>section 5
49184918 </p>
49194919 !! end
——@@ -6118,7 +6118,7 @@
61196119 == onmouseover= ==
61206120 http://__TOC__
61216121 !! result
6122 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: onmouseover=">edit</a>]</span> <span class="mw-headline" id="onmouseover.3D"> onmouseover= </span></h2>
 6122+<h2><span class="mw-headline" id="onmouseover.3D"> onmouseover= </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: onmouseover=">edit</a>]</span></h2>
61236123 http://<div id="toc" class="toc"><div id="toctitle"><h2>Contents</h2></div>
61246124 <ul>
61256125 <li class="toclevel-1 tocsection-1"><a href="#onmouseover.3D"><span class="tocnumber">1</span> <span class="toctext">onmouseover=</span></a></li>
——@@ -6134,7 +6134,7 @@
61356135 {| STYLE=__TOC__
61366136 |foo
61376137 !! result
6138 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: a">edit</a>]</span> <span class="mw-headline" id="a">a</span></h2>
 6138+<h2><span class="mw-headline" id="a">a</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: a">edit</a>]</span></h2>
61396139 <table style="&#95;_TOC&#95;_">
61406140 <tr>
61416141 <td>foo
——@@ -7938,7 +7938,7 @@
79397939 !! input
79407940 {{MediaWiki:Fake}}
79417941 !! result
7942 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=MediaWiki:Fake&amp;action=edit&amp;section=T-1" title="MediaWiki:Fake">edit</a>]</span> <span class="mw-headline" id="header">header</span></h2>
 7942+<h2><span class="mw-headline" id="header">header</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=MediaWiki:Fake&amp;action=edit&amp;section=T-1" title="MediaWiki:Fake">edit</a>]</span></h2>
79437943
79447944 !! end
79457945
——@@ -7969,12 +7969,12 @@
79707970 </li>
79717971 </ul>
79727972 </div>
7973 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: 2">edit</a>]</span> <span class="mw-headline" id="2">2</span></h2>
7974 -<h6><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: 6">edit</a>]</span> <span class="mw-headline" id="6">6</span></h6>
7975 -<h3><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: 3">edit</a>]</span> <span class="mw-headline" id="3">3</span></h3>
7976 -<h1><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: 1">edit</a>]</span> <span class="mw-headline" id="1">1</span></h1>
7977 -<h5><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: 5">edit</a>]</span> <span class="mw-headline" id="5">5</span></h5>
7978 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: 2">edit</a>]</span> <span class="mw-headline" id="2_2">2</span></h2>
 7973+<h2><span class="mw-headline" id="2">2</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: 2">edit</a>]</span></h2>
 7974+<h6><span class="mw-headline" id="6">6</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=2" title="Edit section: 6">edit</a>]</span></h6>
 7975+<h3><span class="mw-headline" id="3">3</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=3" title="Edit section: 3">edit</a>]</span></h3>
 7976+<h1><span class="mw-headline" id="1">1</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=4" title="Edit section: 1">edit</a>]</span></h1>
 7977+<h5><span class="mw-headline" id="5">5</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=5" title="Edit section: 5">edit</a>]</span></h5>
 7978+<h2><span class="mw-headline" id="2_2">2</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=6" title="Edit section: 2">edit</a>]</span></h2>
79797979
79807980 !! end
79817981
——@@ -8081,7 +8081,7 @@
80828082 {{anchorencode: _ +:.3A%3A&&amp;]] }}
80838083 __NOEDITSECTION__
80848084 !! result
8085 -<h3> <span class="mw-headline" id=".2B:.3A.253A.26.26.5D.5D"> _ +:.3A%3A&amp;&amp;]] </span></h3>
 8085+<h3><span class="mw-headline" id=".2B:.3A.253A.26.26.5D.5D"> _ +:.3A%3A&amp;&amp;]] </span> </h3>
80868086 <p>.2B:.3A.253A.26.26.5D.5D
80878087 </p>
80888088 !! end
——@@ -8272,7 +8272,7 @@
82738273 !! input
82748274 == -{Naslov}- ==
82758275 !! result
8276 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Уредите одељак „Naslov“">уреди</a>]</span> <span class="mw-headline" id="-.7BNaslov.7D-"> Naslov </span></h2>
 8276+<h2><span class="mw-headline" id="-.7BNaslov.7D-"> Naslov </span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Уредите одељак „Naslov“">уреди</a>]</span></h2>
82778277
82788278 !! end
82798279
——@@ -8520,7 +8520,7 @@
85218521 !! result
85228522 <p>[[link
85238523 </p>
8524 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: heading">edit</a>]</span> <span class="mw-headline" id="heading">heading</span></h2>
 8524+<h2><span class="mw-headline" id="heading">heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: heading">edit</a>]</span></h2>
85258525
85268526 !! end
85278527
——@@ -8532,7 +8532,7 @@
85338533 !! result
85348534 <p>{{foo|
85358535 </p>
8536 -<h1> <span class="mw-headline" id="heading">heading</span></h1>
 8536+<h1><span class="mw-headline" id="heading">heading</span> </h1>
85378537
85388538 !! end
85398539
——@@ -8544,7 +8544,7 @@
85458545 !! result
85468546 <p>{{foo|
85478547 </p>
8548 -<h2><span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: heading">edit</a>]</span> <span class="mw-headline" id="heading">heading</span></h2>
 8548+<h2><span class="mw-headline" id="heading">heading</span> <span class="editsection">[<a href="https://www.mediawiki.org/index.php?title=Parser_test&amp;action=edit&amp;section=1" title="Edit section: heading">edit</a>]</span></h2>
85498549
85508550 !! end
85518551
Index: trunk/phase3/includes/Linker.php
——@@ -1507,8 +1507,8 @@
15081508 */
15091509 public static function makeHeadline( $level, $attribs, $anchor, $text, $link, $legacyAnchor = false ) {
15101510 $ret = "<h$level$attribs"
 1511+ . "<span class=\"mw-headline\" id=\"$anchor\">$text</span> "
15111512 . $link
1512 - . " <span class=\"mw-headline\" id=\"$anchor\">$text</span>"
15131513 . "</h$level>";
15141514 if ( $legacyAnchor !== false ) {
15151515 $ret = "<div id=\"$legacyAnchor\"></div>$ret";

Follow-up revisions

RevisionCommit summaryAuthorDate
r93387r93386 : Fix LabeledSectionTransclusion parser testsdiebuche13:06, 28 July 2011
r93388Follow-up r93386: fix editsection when user language direction != content lan...robin13:34, 28 July 2011
r93433Revert r93386 -- PLEASE STOP COMMITTING THESE THINGS WITHOUT CONFIRMING THAT ...brion21:41, 28 July 2011
r93434Reverted r93387 due to revert of r93386 in r93433...brion21:46, 28 July 2011
r97746Revert r93388 because it was a fix for r93386 which was reverted.robin16:52, 21 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93284Fix Bug 11270 & Bug 11555 : Make editsection link more understandable by posi...diebuche16:43, 27 July 2011

Comments

#Comment by Nikerabbit (talk | contribs)   12:39, 28 July 2011

CruiseControl complains in LstParserTests: http://ci.tesla.usability.wikimedia.org/cruisecontrol/buildresults/mw?tab=testResults

#Comment by DieBuche (talk | contribs)   13:11, 28 July 2011

Thanks. CruiseControl confirms that it's fixed with r93387

#Comment by Brion VIBBER (talk | contribs)   21:37, 28 July 2011

I think you really need to stop committing these changes until there's some agreement on what's supposed to be going on.

In addition to these swaps back and forth, nothing seems to be updating the parser cache entry versions to match the styles -- this would be a huge deployment problem as previously-rendered pages will render like crap (such as the edit link appearing to the left instead of the right).

#Comment by DieBuche (talk | contribs)   09:18, 29 July 2011

So what's the actual problem with the patch (besides the styleversion, which I forgot, but which could be easily done in a FU) ?

Fun fact: Did you know that Bug 11270 receives a comment on average every 74,6 days ? So should I just attach this to the bug and 2 month later, someone will maybe have time to look at (at which point it will already have started to bitrot)?

#Comment by Hashar (talk | contribs)   12:03, 29 July 2011

I have added a comment to bug 11270 : lets create a branch to work on this bug!

#Comment by Brion VIBBER (talk | contribs)   21:42, 28 July 2011

Reverted in r93433.

#Comment by Raymond (talk | contribs)   09:40, 29 July 2011

That's what extension EditSectionClearerLink (r92919) will do (and more).

Status & tagging log