r93368 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r93367
|
r93368
|
r93369
>
Date:
06:13, 28 July 2011
Author:
nikerabbit
Status:
ok (
Comments
)
Tags:
Comment:
Fu
r93249
: I see no reason to mark this private - protected should be the default value, only use private if you have some reason to. Avoids most of the breakage in out of tree extensions.
Modified paths:
/trunk/phase3/includes/SpecialPage.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/SpecialPage.php
—
—
@@ -31,7 +31,7 @@
32
32
33
33
// The canonical name of this special page
34
34
// Also used for the default <h1> heading, @see getDescription()
35
- private $mName;
35
+ protected $mName;
36
36
37
37
// The local name of this special page
38
38
private $mLocalName;
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r93249
makes SpecialPage::mName explicitly private...
hashar
21:30, 26 July 2011
Comments
#
Comment by
Hashar
(
talk
|
contribs
)
08:57, 28 July 2011
There was now reason for 'private'. I just keep forgetting about 'protected' :-)
Status & tagging log
08:57, 28 July 2011
Hashar
(
talk
|
contribs
)
changed the
status
of r93368
[
removed:
new
added:
ok]