r93249 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93248‎ | r93249 | r93250 >
Date:21:30, 26 July 2011
Author:hashar
Status:resolved (Comments)
Tags:
Comment:
makes SpecialPage::mName explicitly private

Only one occurence in Core : SpecialRandompage.
Extensions are done in a following commit.
Modified paths:
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRandompage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRandompage.php
@@ -65,7 +65,7 @@
6666
6767 if( is_null( $title ) ) {
6868 $this->setHeaders();
69 - $wgOut->addWikiMsg( strtolower( $this->mName ) . '-nopages',
 69+ $wgOut->addWikiMsg( strtolower( $this->getName() ) . '-nopages',
7070 $this->getNsList(), count( $this->namespaces ) );
7171 return;
7272 }
Index: trunk/phase3/includes/SpecialPage.php
@@ -31,7 +31,7 @@
3232
3333 // The canonical name of this special page
3434 // Also used for the default <h1> heading, @see getDescription()
35 - /*private*/ var $mName;
 35+ private $mName;
3636
3737 // The local name of this special page
3838 private $mLocalName;

Follow-up revisions

RevisionCommit summaryAuthorDate
r93250Since r93249 SpecialPage::mName is explicitly private...hashar21:32, 26 July 2011
r93367Fu r93249 failed greppingnikerabbit06:11, 28 July 2011
r93368Fu r93249: I see no reason to mark this private - protected should be the def...nikerabbit06:13, 28 July 2011

Comments

#Comment by 😂 (talk | contribs)   18:25, 5 August 2011

Was made protected in r93368, marking this resolved.

Status & tagging log