r93264 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93263‎ | r93264 | r93265 >
Date:13:24, 27 July 2011
Author:diebuche
Status:reverted (Comments)
Tags:
Comment:
Remove semantically incorrect wrapper table from toc and replace it with an inline-blocked diff. Update some skin css, since we don't have the implicit table padding anymore and need to increase to padding to maintain the current look. Bug 13766
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1456,10 +1456,10 @@
14571457 static function tocList( $toc, $lang = false ) {
14581458 $title = wfMsgExt( 'toc', array( 'language' => $lang, 'escape' ) );
14591459 return
1460 - '<table id="toc" class="toc"><tr><td>'
 1460+ '<div id="toc" class="toc">'
14611461 . '<div id="toctitle"><h2>' . $title . "</h2></div>\n"
14621462 . $toc
1463 - . "</ul>\n</td></tr></table>\n";
 1463+ . "</ul>\n</div>\n";
14641464 }
14651465
14661466 /**
Index: trunk/phase3/skins/vector/screen.css
@@ -884,8 +884,7 @@
885885 .toc ul {
886886 list-style-type: none;
887887 list-style-image: none;
888 - margin-left: 0;
889 - padding-left: 0;
 888+ padding: 0 .4em;
890889 text-align: left;
891890 }
892891 #toc ul ul,
Index: trunk/phase3/skins/monobook/main.css
@@ -348,8 +348,7 @@
349349 .toc ul {
350350 list-style-type: none;
351351 list-style-image: none;
352 - margin-left: 0;
353 - padding-left: 0;
 352+ padding: 0 .4em;
354353 text-align: left;
355354 }
356355 #toc ul ul,
Index: trunk/phase3/skins/modern/main.css
@@ -556,11 +556,6 @@
557557 border: solid 1px #bbb;
558558 }
559559
560 -#toc tr, #toc td {
561 - margin: 0;
562 - padding: 0;
563 -}
564 -
565560 #toctitle {
566561 border-bottom: solid 1px #3c78b5;
567562 background-color: #ddd;
@@ -587,7 +582,7 @@
588583 list-style-type: none;
589584 list-style-image: none;
590585 margin: 0 1em;
591 - padding-left: 0;
 586+ padding: 0;
592587 text-align: left;
593588 }
594589
Index: trunk/phase3/skins/common/shared.css
@@ -783,4 +783,14 @@
784784 }
785785
786786 /* bug 12205 */
787 -#mw-credits a { unicode-bidi: embed; }
\ No newline at end of file
 787+#mw-credits a {
 788+ unicode-bidi: embed;
 789+}
 790+
 791+/* Standard toc */
 792+#toc {
 793+ display: inline-block;
 794+ /* IE6+7 workaround */
 795+ zoom: 1;
 796+ display: inline !ie;
 797+}
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r93298revert r93264 : breaks ton of parser tests....hashar19:20, 27 July 2011
r93319Recommit r93264 ( Remove semantically incorrect wrapper table from toc and re...diebuche21:53, 27 July 2011

Comments

#Comment by Siebrand (talk | contribs)   13:58, 27 July 2011

Needs RELEASE-NOTES entry.

Status & tagging log