r93298 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93297‎ | r93298 | r93299 >
Date:19:20, 27 July 2011
Author:hashar
Status:ok
Tags:
Comment:
revert r93264 : breaks ton of parser tests.

Please update the parser tests and reapply.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -356,7 +356,8 @@
357357 .toc ul {
358358 list-style-type: none;
359359 list-style-image: none;
360 - padding: 0 .4em;
 360+ margin-left: 0;
 361+ padding-left: 0;
361362 text-align: left;
362363 }
363364 #toc ul ul,
Index: trunk/phase3/skins/modern/main.css
@@ -561,6 +561,11 @@
562562 border: solid 1px #bbb;
563563 }
564564
 565+#toc tr, #toc td {
 566+ margin: 0;
 567+ padding: 0;
 568+}
 569+
565570 #toctitle {
566571 border-bottom: solid 1px #3c78b5;
567572 background-color: #ddd;
@@ -587,7 +592,7 @@
588593 list-style-type: none;
589594 list-style-image: none;
590595 margin: 0 1em;
591 - padding: 0;
 596+ padding-left: 0;
592597 text-align: left;
593598 }
594599
Index: trunk/phase3/skins/common/shared.css
@@ -791,14 +791,4 @@
792792 }
793793
794794 /* bug 12205 */
795 -#mw-credits a {
796 - unicode-bidi: embed;
797 -}
798 -
799 -/* Standard toc */
800 -#toc {
801 - display: inline-block;
802 - /* IE6+7 workaround */
803 - zoom: 1;
804 - display: inline !ie;
805 -}
\ No newline at end of file
 795+#mw-credits a { unicode-bidi: embed; }
\ No newline at end of file
Index: trunk/phase3/skins/vector/screen.css
@@ -883,7 +883,8 @@
884884 .toc ul {
885885 list-style-type: none;
886886 list-style-image: none;
887 - padding: 0 .4em;
 887+ margin-left: 0;
 888+ padding-left: 0;
888889 text-align: left;
889890 }
890891 #toc ul ul,
Index: trunk/phase3/includes/Linker.php
@@ -1456,10 +1456,10 @@
14571457 static function tocList( $toc, $lang = false ) {
14581458 $title = wfMsgExt( 'toc', array( 'language' => $lang, 'escape' ) );
14591459 return
1460 - '<div id="toc" class="toc">'
 1460+ '<table id="toc" class="toc"><tr><td>'
14611461 . '<div id="toctitle"><h2>' . $title . "</h2></div>\n"
14621462 . $toc
1463 - . "</ul>\n</div>\n";
 1463+ . "</ul>\n</td></tr></table>\n";
14641464 }
14651465
14661466 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93264Remove semantically incorrect wrapper table from toc and replace it with an i...diebuche13:24, 27 July 2011

Status & tagging log