r92715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92714‎ | r92715 | r92716 >
Date:23:51, 20 July 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
Revert non-functional parts of r82343 -- 'select' parameter that's never actually been exported or used, and was always being forced to true before being discarded anyway.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -2330,10 +2330,8 @@
23312331 * filename of the button image (without path), the opening
23322332 * tag, the closing tag, optionally a sample text that is
23332333 * inserted between the two when no selection is highlighted
2334 - * and an option to select which switches the automatic
2335 - * selection of inserted text (default is true, see
2336 - * mw-editbutton-image). The tip text is shown when the user
2337 - * moves the mouse over the button.
 2334+ * and. The tip text is shown when the user moves the mouse
 2335+ * over the button.
23382336 *
23392337 * Also here: accesskeys (key), which are not used yet until
23402338 * someone can figure out a way to make them work in
@@ -2394,7 +2392,6 @@
23952393 'sample' => wfMsg( 'image_sample' ),
23962394 'tip' => wfMsg( 'image_tip' ),
23972395 'key' => 'D',
2398 - 'select' => true
23992396 ) : false,
24002397 $imagesAvailable ? array(
24012398 'image' => $wgLang->getImageFile( 'button-media' ),
@@ -2450,10 +2447,6 @@
24512448 continue;
24522449 }
24532450
2454 - if( !isset( $tool['select'] ) ) {
2455 - $tool['select'] = true;
2456 - }
2457 -
24582451 $params = array(
24592452 $image = $wgStylePath . '/common/images/' . $tool['image'],
24602453 // Note that we use the tip both for the ALT tag and the TITLE tag of the image.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82343Followup bug #27447 and r82308 and r82328 with patch supplied by...mah18:41, 17 February 2011

Comments

#Comment by Nikerabbit (talk | contribs)   06:22, 21 July 2011
inserted between the two when no selection is highlighted and.  The tip text is shown when the user moves the mouse

... and what?

Status & tagging log