r92714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92713‎ | r92714 | r92715 >
Date:23:47, 20 July 2011
Author:purodha
Status:deferred
Tags:
Comment:
Fix table installer not working due to missing return value.
Add error message to table installer for unsupported data base types.
Modified paths:
  • /trunk/extensions/AdvancedMeta/AdvancedMeta.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AdvancedMeta/AdvancedMeta.php
@@ -32,10 +32,16 @@
3333 function efAdvancedMetaSchemaUpdates( $updater ) {
3434 $base = dirname( __FILE__ );
3535 switch ( $updater->getDB()->getType() ) {
36 - case 'mysql':
37 - $updater->addExtensionUpdate( array( 'addTable', 'ext_meta',
38 - "$base/AdvancedMeta.sql", true ) ); // Initial install tables
 36+ case 'mysql':
 37+ $updater->addExtensionUpdate( array( 'addTable', 'ext_meta',
 38+ "$base/AdvancedMeta.sql", true ) ); // Initially install tables
 39+ break;
 40+ default:
 41+ print"\n".
 42+ "There are no table structures for the AdvancedMeta\n".
 43+ "extension for your data base type at the moment.\n\n";
3944 }
 45+ return True;
4046 }
4147
4248 class MWAdvancedMeta {
@@ -421,4 +427,4 @@
422428 || count(array_intersect($wgUser->getGroups(), $this->allowedUsergroups)) !== 0
423429 );
424430 }
425 -}
\ No newline at end of file
 431+}

Status & tagging log