r92294 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92293‎ | r92294 | r92295 >
Date:20:05, 15 July 2011
Author:reedy
Status:resolved
Tags:
Comment:
1.17wmf1 MFT r91573
Modified paths:
  • /branches/wmf/1.17wmf1/includes/ImageGallery.php (modified) (history)
  • /branches/wmf/1.17wmf1/skins/common/shared.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/skins/common/shared.css
@@ -781,6 +781,11 @@
782782 margin: 2px;
783783 }
784784
 785+li.gallerybox div.thumb img {
 786+ display: block;
 787+ margin: 0 auto;
 788+}
 789+
785790 div.gallerytext {
786791 overflow: hidden;
787792 font-size: 94%;
Property changes on: branches/wmf/1.17wmf1/skins/common/shared.css
___________________________________________________________________
Modified: svn:mergeinfo
788793 Merged /trunk/phase3/skins/common/shared.css:r91573
Index: branches/wmf/1.17wmf1/includes/ImageGallery.php
@@ -276,8 +276,8 @@
277277 $thumbhtml = "\n\t\t\t".'<div style="height: '.(30 + $this->mHeights).'px;">'
278278 . htmlspecialchars( $img->getLastError() ) . '</div>';
279279 } else {
280 - $vpad = floor(( 30 + $this->mHeights - $thumb->height ) /2);
281 -
 280+ $vpad = ( self::THUMB_PADDING + $this->mHeights - $thumb->height ) /2;
 281+
282282 $imageParameters = array(
283283 'desc-link' => true,
284284 'desc-query' => $descQuery

Follow-up revisions

RevisionCommit summaryAuthorDate
r92310Followup r92294, self::THUMB_PADDING isn't defined in 1.17reedy21:38, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91573refixing bug 27338 with all parser test fixes, reverts r91557kaldari18:07, 6 July 2011

Status & tagging log