r92310 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92309‎ | r92310 | r92311 >
Date:21:38, 15 July 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r92294, self::THUMB_PADDING isn't defined in 1.17
Modified paths:
  • /branches/wmf/1.17wmf1/includes/ImageGallery.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/ImageGallery.php
@@ -276,7 +276,7 @@
277277 $thumbhtml = "\n\t\t\t".'<div style="height: '.(30 + $this->mHeights).'px;">'
278278 . htmlspecialchars( $img->getLastError() ) . '</div>';
279279 } else {
280 - $vpad = ( self::THUMB_PADDING + $this->mHeights - $thumb->height ) /2;
 280+ $vpad = ( 30/*self::THUMB_PADDING*/ + $this->mHeights - $thumb->height ) /2;
281281
282282 $imageParameters = array(
283283 'desc-link' => true,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r922941.17wmf1 MFT r91573reedy20:05, 15 July 2011

Status & tagging log