r92212 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92211‎ | r92212 | r92213 >
Date:23:00, 14 July 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r92042 - making more localizable
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/special/SpecialCentralNoticeLogs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialCentralNoticeLogs.php
@@ -160,7 +160,7 @@
161161 $wgLang->date( $row->notlog_timestamp ) . ' ' . $wgLang->time( $row->notlog_timestamp )
162162 );
163163 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
164 - $userLink.' ('.$userTalkLink.')'
 164+ wfMsg ( 'centralnotice-user-links', $userLink, $userTalkLink )
165165 );
166166 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
167167 $row->notlog_action
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -159,6 +159,7 @@
160160 'centralnotice-banners-changed' => 'Banner assignments were changed',
161161 'centralnotice-no-assignments' => 'no banners assigned',
162162 'centralnotice-talk-link' => 'talk',
 163+ 'centralnotice-user-links' => '$1 ($2)',
163164 );
164165
165166 /** Message documentation (Message documentation)
@@ -249,6 +250,7 @@
250251 'centralnotice-action' => '{{Identical|Action}}',
251252 'centralnotice-no-assignments' => 'Appears in the middle of a sentence; should be all lower case.',
252253 'centralnotice-talk-link' => 'Link for user talk page; should be lower case.',
 254+ 'centralnotice-user-links' => '$1 is a link to the user page, $2 is a link to the user talk page.',
253255 );
254256
255257 /** Afrikaans (Afrikaans)

Follow-up revisions

RevisionCommit summaryAuthorDate
r92243Followup r92224/r92212: optional for Translatewikiraymond14:47, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92042adding direct link to user talk page from log entrieskaldari00:57, 13 July 2011

Status & tagging log