r92042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92041‎ | r92042 | r92043 >
Date:00:57, 13 July 2011
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
adding direct link to user talk page from log entries
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/special/SpecialCentralNoticeLogs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialCentralNoticeLogs.php
@@ -137,6 +137,8 @@
138138 // Create the user page link
139139 $userLink = $this->getSkin()->makeLinkObj( $loggedUser->getUserPage(),
140140 $loggedUser->getName() );
 141+ $userTalkLink = $this->getSkin()->makeLinkObj( $loggedUser->getTalkPage(),
 142+ wfMsg ( 'centralnotice-talk-link' ) );
141143
142144 // Create the campaign link
143145 $campaignLink = $this->getSkin()->makeLinkObj( $this->viewPage,
@@ -158,7 +160,7 @@
159161 $wgLang->date( $row->notlog_timestamp ) . ' ' . $wgLang->time( $row->notlog_timestamp )
160162 );
161163 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
162 - $userLink
 164+ $userLink.' ('.$userTalkLink.')'
163165 );
164166 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class' => 'primary' ),
165167 $row->notlog_action
@@ -337,13 +339,13 @@
338340 $htmlOut .= Xml::element( 'th', array( 'align' => 'left', 'style' => 'width: 130px;' ),
339341 wfMsg ( 'centralnotice-timestamp' )
340342 );
341 - $htmlOut .= Xml::element( 'th', array( 'align' => 'left', 'style' => 'width: 130px;' ),
 343+ $htmlOut .= Xml::element( 'th', array( 'align' => 'left', 'style' => 'width: 160px;' ),
342344 wfMsg ( 'centralnotice-user' )
343345 );
344 - $htmlOut .= Xml::element( 'th', array( 'align' => 'left', 'style' => 'width: 130px;' ),
 346+ $htmlOut .= Xml::element( 'th', array( 'align' => 'left', 'style' => 'width: 100px;' ),
345347 wfMsg ( 'centralnotice-action' )
346348 );
347 - $htmlOut .= Xml::element( 'th', array( 'align' => 'left', 'style' => 'width: 130px;' ),
 349+ $htmlOut .= Xml::element( 'th', array( 'align' => 'left', 'style' => 'width: 160px;' ),
348350 wfMsg ( 'centralnotice-notice' )
349351 );
350352 $htmlOut .= Xml::tags( 'td', array(),
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -158,6 +158,7 @@
159159 'centralnotice-removed' => 'Removed <span class="cn-old-value">$1</span>',
160160 'centralnotice-banners-changed' => 'Banner assignments were changed',
161161 'centralnotice-no-assignments' => 'no banners assigned',
 162+ 'centralnotice-talk-link' => 'talk',
162163 );
163164
164165 /** Message documentation (Message documentation)
@@ -247,6 +248,7 @@
248249 'centralnotice-user' => '{{Identical|User}}',
249250 'centralnotice-action' => '{{Identical|Action}}',
250251 'centralnotice-no-assignments' => 'Appears in the middle of a sentence; should be all lower case.',
 252+ 'centralnotice-talk-link' => 'Link for user talk page; should be lower case.',
251253 );
252254
253255 /** Afrikaans (Afrikaans)

Follow-up revisions

RevisionCommit summaryAuthorDate
r92212follow-up to r92042 - making more localizablekaldari23:00, 14 July 2011

Comments

#Comment by Awjrichards (talk | contribs)   21:57, 14 July 2011

marking fixme to remind kaldari to dbl check with i18n guys about the link generation/punctuation

#Comment by Kaldari (talk | contribs)   23:01, 14 July 2011

fixed in r92212

Status & tagging log