r92062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92061‎ | r92062 | r92063 >
Date:13:33, 13 July 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Follow-up r92054: dir attributes are no longer needed (displays it incorrectly when user direction != content direction)
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -522,7 +522,7 @@
523523 }
524524
525525 function getCategoryLinks() {
526 - global $wgUseCategoryBrowser, $wgContLang;
 526+ global $wgUseCategoryBrowser;
527527
528528 $out = $this->getContext()->getOutput();
529529
@@ -530,10 +530,7 @@
531531 return '';
532532 }
533533
534 - // Use Unicode bidi embedding override characters,
535 - // to make sure links don't smash each other up in ugly ways.
536 - $dir = $wgContLang->getDir();
537 - $embed = "<li dir='$dir'>";
 534+ $embed = "<li>";
538535 $pop = "</li>";
539536
540537 $allCats = $out->getCategoryLinks();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92054Render category links as an HTML list. Bug 12261. Based on patch by Thana & B...diebuche10:41, 13 July 2011

Comments

#Comment by DieBuche (talk | contribs)   14:09, 13 July 2011

I wanted to ask you whether it was still needed... : )

#Comment by SPQRobin (talk | contribs)   14:47, 13 July 2011

:-) In any case, it was easily observable with &uselang=ar (on an LTR wiki).

Status & tagging log