r92063 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92062‎ | r92063 | r92064 >
Date:14:04, 13 July 2011
Author:robin
Status:ok
Tags:
Comment:
Follow-up r91519: ellipsis was not included in the trimmed commit messages in list view -> move mw-codereview-message to CodeRevisionView (CSS was set for the list view anyway in r91519)
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeView.php
@@ -57,8 +57,7 @@
5858
5959 function formatMessage( $text ) {
6060 $text = nl2br( htmlspecialchars( $text ) );
61 - return Html::rawElement( 'div', array( 'class' => 'mw-codereview-message' ),
62 - $this->codeCommentLinkerHtml->link( $text ) );
 61+ return $this->codeCommentLinkerHtml->link( $text );
6362 }
6463
6564 function messageFragment( $value ) {
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -123,7 +123,8 @@
124124 'code-rev-author' => $this->authorLink( $this->mRev->getAuthor() ),
125125 'code-rev-status' => $this->statusForm() . $commentsLink,
126126 'code-rev-tags' => $this->tagForm(),
127 - 'code-rev-message' => $this->formatMessage( $this->mRev->getMessage() ),
 127+ 'code-rev-message' => Html::rawElement( 'div', array( 'class' => 'mw-codereview-message' ),
 128+ $this->formatMessage( $this->mRev->getMessage() ) ),
128129 'code-rev-paths' => $paths,
129130 );
130131 $special = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $this->mRev->getId() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91519(follow-up r91518; bug 29658 et al.) Improving RTL support for several extens...robin02:44, 6 July 2011

Status & tagging log