r91833 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91832‎ | r91833 | r91834 >
Date:14:56, 10 July 2011
Author:diebuche
Status:resolved
Tags:
Comment:
Escape sidebar ID's. Bug 18688
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1330,7 +1330,7 @@
13311331 $bar[$heading][] = array_merge( array(
13321332 'text' => $text,
13331333 'href' => $href,
1334 - 'id' => 'n-' . strtr( $line[1], ' ', '-' ),
 1334+ 'id' => 'n-' . Sanitizer::escapeId( strtr( $line[1], ' ', '-' ) ),
13351335 'active' => false
13361336 ), $extraAttribs );
13371337 } elseif ( ( substr( $line, 0, 2 ) == '{{' ) && ( substr( $line, -2 ) == '}}' ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r91932Followup r91833 -- use Sanitizer::escapeId's 'noninitial' option when generat...brion00:25, 12 July 2011

Status & tagging log