r91834 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91833‎ | r91834 | r91835 >
Date:15:27, 10 July 2011
Author:krinkle
Status:ok
Tags:
Comment:
Removing @broken comment. Not anymore, they don't as of r91388.
- (Follows-up 91387)
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js
@@ -32,7 +32,6 @@
3333 strictEqual( conf.set( arry, 'Arry' ), false, 'Map.set returns boolean false if key was invalid (Array)' );
3434 strictEqual( conf.set( nummy, 'Nummy' ), false, 'Map.set returns boolean false if key was invalid (Number)' );
3535 equal( conf.get( 'myKey' ), 'myValue', 'Map.get returns a single value value correctly' );
36 - // @broken (these currently return the values object)
3736 strictEqual( conf.get( nummy ), null, 'Map.get ruturns null if selection was invalid (Number)' );
3837 strictEqual( conf.get( funky ), null, 'Map.get ruturns null if selection was invalid (Function)' );
3938

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91388Fix for the broken tests introduced in r91387....krinkle23:24, 3 July 2011

Status & tagging log