r91570 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91569‎ | r91570 | r91571 >
Date:17:58, 6 July 2011
Author:demon
Status:resolved
Tags:
Comment:
Call parent::setUp() and allow it to do lang setup stuff
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/GlobalFunctions/GlobalTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/GlobalFunctions/GlobalTest.php
@@ -3,13 +3,12 @@
44 class GlobalTest extends MediaWikiTestCase {
55 function setUp() {
66 global $wgReadOnlyFile, $wgContLang, $wgLang, $wgUrlProtocols, $wgLanguageCode;
 7+ parent::setUp();
78 $this->originals['wgReadOnlyFile'] = $wgReadOnlyFile;
89 $this->originals['wgUrlProtocols'] = $wgUrlProtocols;
910 $wgReadOnlyFile = tempnam( wfTempDir(), "mwtest_readonly" );
1011 $wgUrlProtocols[] = 'file://';
1112 unlink( $wgReadOnlyFile );
12 - $wgLanguageCode = 'en';
13 - $wgContLang = $wgLang = Language::factory( 'en' );
1413 }
1514
1615 function tearDown() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r92576Remove the globals. r91570 was wrong saying that parent::setUp()...platonides21:05, 19 July 2011

Status & tagging log