r92576 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92575‎ | r92576 | r92577 >
Date:21:05, 19 July 2011
Author:platonides
Status:ok
Tags:
Comment:
Remove the globals. r91570 was wrong saying that parent::setUp()
would initialise those vars (this class parent is MediaWikiTestCase,
not MediaWikiLangTestCase) but the language doesn't seem to matter.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/GlobalFunctions/GlobalTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/GlobalFunctions/GlobalTest.php
——@@ -2,8 +2,7 @@
33
44 class GlobalTest extends MediaWikiTestCase {
55 function setUp() {
6 - global $wgReadOnlyFile, $wgContLang, $wgLang, $wgUrlProtocols, $wgLanguageCode;
7 - parent::setUp();
 6+ global $wgReadOnlyFile, $wgUrlProtocols;
87 $this->originals['wgReadOnlyFile'] = $wgReadOnlyFile;
98 $this->originals['wgUrlProtocols'] = $wgUrlProtocols;
109 $wgReadOnlyFile = tempnam( wfTempDir(), "mwtest_readonly" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r92586Merge code cleanup revisions so that code analysis can also be performed in t...platonides21:29, 19 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91570Call parent::setUp() and allow it to do lang setup stuffdemon17:58, 6 July 2011

Status & tagging log